Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Refactoring: Clarify contract of labelable elements management

Download Browse

Part of story #10501: Manage project labels Instead of having multiple dedicated events, we can clarify the contract of LabelableDao and return the dao instead. That way, when we manage project labels, we are more confident about the behavior of plugins: instead of trusting the behavior behind three separate events (get, delete, merge) this is now the responsibility of the core to execute respective queries, knowing that the plugins respect the LabelableDao. Change-Id: I556907cbeebb030e66bad8dd756fe91b35b58672

+73 −163
Nicolas Terray (nterray) 2017-09-23 09:51
Nicolas Terray (nterray) 2017-09-23 09:58
db52902b3b816f55a60a4ffe0f2cae83bb0a054e
b095208fb1f183a1b1abe89aaefcf4094b9efa8f
git #tuleap/stable/db52902b3b816f55a60a4ffe0f2cae83bb0a054e

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/include/pullrequestPlugin.class.php +4 −27 Go to diff View file
R src/common/project/Label/DeleteProjectLabelInTransaction.php Go to diff View file
M src/common/Label/LabelableDao.php +19 −0 Go to diff View file
M src/common/autoload.php +3 −2 Go to diff View file
M src/common/project/Label/CollectionOfLabelPresenter.php +1 −21 Go to diff View file
M src/common/project/Label/DeleteController.php +10 −8 Go to diff View file
M src/common/project/Label/EditController.php +12 −11 Go to diff View file
M src/common/project/Label/IndexController.php +17 −14 Go to diff View file
D src/common/project/Label/MergeProjectLabelInTransaction.php +0 −77 Go to diff View file
M src/www/project/admin/labels.php +7 −3 Go to diff View file