stable
Clone or download
Read-only
request #10364: Use a module-loader for planning-v2
Sorry (again) for the giant review. No functional changes are expected. How to test: - bower prune; bower install (we still need bower for the modal and angular-ui-bootstrap) - npm install in planning-v2 dir - npm run build in tuleap root - npm run build should now: - build the SCSS files to planning-v2/dist/planning-v2.css - build and minify the JS files to planning-v2/dist/planning-v2-[hash].js - copy all used images to planning-v2/dist/ - npm run test should run unit tests once - npm run coverage should run unit tests once and show test coverage html on your browser - npm run watch should: - watch js files and rebuild, run unit tests and extract gettext - watch and build SCSS files Some of the things that were done in gruntfile have not been migrated: - adding a banner to the generated minified file - using ng-annotate. We use $inject everywhere, so it shouldn't be necessary - running eslint. This will be done as a separate task as eslint is not essential for our dev process and needs to be upgraded anyway. Change-Id: I569f55b91662195752a954a6fee09330b32b98c4
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | gulpfile.js | +5 | −2 | Go to diff View file |
| M | plugins/agiledashboard/include/agiledashboardPlugin.class.php | +8 | −2 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/.eslintrc.json | +5 | −1 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/.gitignore | +2 | −3 | Go to diff View file |
| D | plugins/agiledashboard/www/js/planning-v2/Gruntfile.js | +0 | −504 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/bower.json | +1 | −15 | Go to diff View file |
| D | plugins/agiledashboard/www/js/planning-v2/build.config.js | +0 | −93 | Go to diff View file |
| A | plugins/agiledashboard/www/js/planning-v2/gulpfile.js | +69 | −0 | Go to diff View file |
| A | plugins/agiledashboard/www/js/planning-v2/karma.conf.js | +81 | −0 | Go to diff View file |
| D | plugins/agiledashboard/www/js/planning-v2/karma.config.js | +0 | −50 | Go to diff View file |
| D | plugins/agiledashboard/www/js/planning-v2/module.prefix | +0 | −1 | Go to diff View file |
| D | plugins/agiledashboard/www/js/planning-v2/module.suffix | +0 | −1 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/package-lock.json | +4181 | −1669 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/package.json | +43 | −26 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/app-config.js | +15 | −6 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/app-planning-controller.js | +3 | −3 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/app-planning-controller.spec.js | +20 | −11 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/app.js | +56 | −16 | Go to diff View file |
| A | plugins/agiledashboard/www/js/planning-v2/src/app/app.spec.js | +15 | −0 | Go to diff View file |
| A | plugins/agiledashboard/www/js/planning-v2/src/app/backlog-filter-terms.js | +3 | −0 | Go to diff View file |
| D | plugins/agiledashboard/www/js/planning-v2/src/app/backlog-filterterms/backlog-filter-value.js | +0 | −5 | Go to diff View file |
| D | plugins/agiledashboard/www/js/planning-v2/src/app/backlog-filterterms/backlog-filterterms.js | +0 | −3 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/backlog-item-collection/backlog-item-collection-service.js | +3 | −3 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/backlog-item-collection/backlog-item-collection-service.spec.js | +11 | −3 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/backlog-item-collection/backlog-item-collection.js | +11 | −3 | Go to diff View file |
| R | plugins/agiledashboard/www/js/planning-v2/src/app/backlog-item/backlog-item-factory.js | Go to diff View file | ||
| R | plugins/agiledashboard/www/js/planning-v2/src/app/backlog-item/backlog-item-factory.spec.js | Go to diff View file | ||
| A | plugins/agiledashboard/www/js/planning-v2/src/app/backlog-item-rest/backlog-item-rest.js | +11 | −0 | Go to diff View file |
| R | plugins/agiledashboard/www/js/planning-v2/src/app/backlog-item/backlog-item-service.js | Go to diff View file | ||
| R | plugins/agiledashboard/www/js/planning-v2/src/app/backlog-item/backlog-item-service.spec.js | Go to diff View file | ||
| M | plugins/agiledashboard/www/js/planning-v2/src/app/backlog-item-selected/backlog-item-select-directive.js | +1 | −3 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/backlog-item-selected/backlog-item-selected-bar-controller.js | +3 | −3 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/backlog-item-selected/backlog-item-selected-bar-directive.js | +7 | −9 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/backlog-item-selected/backlog-item-selected-service.js | +3 | −3 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/backlog-item-selected/backlog-item-selected.js | +12 | −1 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/backlog-item/backlog-item-controller.js | +4 | −4 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/backlog-item/backlog-item-controller.spec.js | +21 | −5 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/backlog-item/backlog-item-details/backlog-item-details-controller.js | +7 | −7 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/backlog-item/backlog-item-details/backlog-item-details-controller.spec.js | +15 | −5 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/backlog-item/backlog-item-details/backlog-item-details-directive.js | +7 | −7 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/backlog-item/backlog-item-details/backlog-item-details.js | +18 | −7 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/backlog-item/backlog-item-directive.js | +7 | −7 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/backlog-item/backlog-item.js | +23 | −7 | Go to diff View file |
| A | plugins/agiledashboard/www/js/planning-v2/src/app/backlog-rest/backlog-rest.js | +13 | −0 | Go to diff View file |
| R | plugins/agiledashboard/www/js/planning-v2/src/app/backlog/backlog-service.js | Go to diff View file | ||
| R | plugins/agiledashboard/www/js/planning-v2/src/app/backlog/backlog-service.spec.js | Go to diff View file | ||
| M | plugins/agiledashboard/www/js/planning-v2/src/app/backlog/backlog-controller.js | +7 | −7 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/backlog/backlog-controller.spec.js | +27 | −11 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/backlog/backlog-directive.js | +7 | −7 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/backlog/backlog.js | +31 | −10 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/card-fields/card-computed-field/card-computed-field-directive.js | +3 | −5 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/card-fields/card-fields-service.js | +6 | −7 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/card-fields/card-fields.js | +16 | −3 | Go to diff View file |
| A | plugins/agiledashboard/www/js/planning-v2/src/app/drop/drop.js | +15 | −0 | Go to diff View file |
| R | plugins/agiledashboard/www/js/planning-v2/src/app/dropped-service.js | Go to diff View file | ||
| R | plugins/agiledashboard/www/js/planning-v2/src/app/dropped-service.spec.js | Go to diff View file | ||
| M | plugins/agiledashboard/www/js/planning-v2/src/app/edit-item/edit-item-service.js | +2 | −6 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/edit-item/edit-item.js | +14 | −4 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/highlight-filter/highlight-filter.js | +7 | −3 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/highlight-filter/highlight-filter.spec.js | +63 | −54 | Go to diff View file |
| R | plugins/agiledashboard/www/js/planning-v2/src/app/in-properties-filter/in-properties-filter.js | Go to diff View file | ||
| R | plugins/agiledashboard/www/js/planning-v2/src/app/in-properties-filter/in-properties-filter.spec.js | Go to diff View file | ||
| A | plugins/agiledashboard/www/js/planning-v2/src/app/in-properties/in-properties.js | +10 | −0 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/infinite-scroll/infinite-scroll-directive.js | +3 | −3 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/infinite-scroll/infinite-scroll.js | +8 | −1 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/main-controller.js | +5 | −7 | Go to diff View file |
| R | plugins/agiledashboard/www/js/planning-v2/src/app/milestone-collection-service.js | Go to diff View file | ||
| R | plugins/agiledashboard/www/js/planning-v2/src/app/milestone-collection-service.spec.js | Go to diff View file | ||
| A | plugins/agiledashboard/www/js/planning-v2/src/app/milestone-collection/milestone-collection.js | +13 | −0 | Go to diff View file |
| A | plugins/agiledashboard/www/js/planning-v2/src/app/milestone-rest/milestone-rest.js | +13 | −0 | Go to diff View file |
| R | plugins/agiledashboard/www/js/planning-v2/src/app/milestone/milestone-service.js | Go to diff View file | ||
| R | plugins/agiledashboard/www/js/planning-v2/src/app/milestone/milestone-service.spec.js | Go to diff View file | ||
| M | plugins/agiledashboard/www/js/planning-v2/src/app/milestone/milestone-controller.js | +2 | −3 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/milestone/milestone-controller.spec.js | +19 | −4 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/milestone/milestone-directive.js | +7 | −7 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/milestone/milestone.js | +19 | −7 | Go to diff View file |
| A | plugins/agiledashboard/www/js/planning-v2/src/app/modal-moment-fix.js | +5 | −0 | Go to diff View file |
| R | plugins/agiledashboard/www/js/planning-v2/src/app/main.scss | Go to diff View file | ||
| M | plugins/agiledashboard/www/js/planning-v2/src/app/project/project-service.js | +1 | −3 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/project/project.js | +9 | −2 | Go to diff View file |
| R | plugins/agiledashboard/www/js/planning-v2/src/app/rest-error-service.js | Go to diff View file | ||
| A | plugins/agiledashboard/www/js/planning-v2/src/app/rest-error/rest-error.js | +8 | −0 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/shared-properties/shared-properties-service.js | +1 | −5 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/shared-properties/shared-properties.js | +8 | −1 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/user-preferences/user-preferences-service.js | +1 | −3 | Go to diff View file |
| M | plugins/agiledashboard/www/js/planning-v2/src/app/user-preferences/user-preferences.js | +10 | −1 | Go to diff View file |
| A | plugins/agiledashboard/www/js/planning-v2/webpack.config.js | +105 | −0 | Go to diff View file |
| M | tools/rpm/Makefile | +2 | −2 | Go to diff View file |