Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

request #11463: Misleading error message when trying to delete an artifact via REST

Download Browse

When the site admin set the limit in artifact deletion configuration to 0, it means that nobody can delete an artifact. In that case, when I try DELETE /artifacts/:id, I should get a 403 Forbidden instead of: "429 Too many requests" with error message "The limit of artifacts deletions has been reached for the previous 24 hours". When the user did not delete any artifacts in the previous 24 hours, this message is wrong. Change-Id: Ic00e37fffe241e9f52f146fe2a60d2e3902f6227

+47 −4
Nicolas Terray (nterray) 2018-05-04 20:48
Yannis ROSSETTO (rossettoy) 2018-05-07 10:46
e20ee1ce494f5640da625ab5cde065e1fd83aee3
5675c6c5c2e6df33f3952883934f65aa051da8c6
git #tuleap/stable/e20ee1ce494f5640da625ab5cde065e1fd83aee3

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/REST/v1/ArtifactsResource.class.php +4 −1 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/ArtifactsDeletion/ArtifactsDeletionManager.php +7 −1 Go to diff View file
A plugins/tracker/include/Tracker/Artifact/ArtifactsDeletion/DeletionOfArtifactsIsNotAllowedException.php +33 −0 Go to diff View file
M plugins/tracker/include/autoload.php +3 −2 Go to diff View file