stable

Clone or download

Read-only

refactor: stop using Tracker_ArtifactLinkInfo

part of story #24969 [modal] add and remove links without types No functional change expected. Tracker_ArtifactLinkInfo can call the database and will make us mock it all the time. We should use our own concept of link instead. I also put an interface in front of ArtifactLink because it relied too much on REST payload format. We are not doing hexagonal architecture here, but it would still be nice to have a separation between "sort-of domain objects" and the REST API. Change-Id: Icbea62a4228f09d5c09e30fec57e230a2f633cd4

Modified Files

Name
R plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLink.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactForwardLinksInfoRetriever.php Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksByChangesetCache.php +4 −4 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksDiff.php +6 −4 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksFieldUpdateValue.php +6 −5 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksFieldUpdateValueBuilder.php +3 −9 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksFieldUpdateValueFormatter.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksPayloadExtractor.php +2 −1 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactParentLinkPayloadExtractor.php +4 −2 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/CollectionOfArtifactLinks.php +11 −6 Go to diff View file
R plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/CollectionOfArtifactLinksInfo.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/RetrieveForwardLinksInfo.php Go to diff View file
A plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/StoredLink.php +58 −0 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_ArtifactLink.php +2 −2 Go to diff View file
R plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinkTest.php Go to diff View file
A plugins/tracker/tests/unit/Stub/LinkStub.php +55 −0 Go to diff View file
R plugins/tracker/tests/unit/Stub/RetrieveForwardLinksInfoStub.php Go to diff View file
D plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactForwardLinksInfoRetrieverTest.php +0 −199 Go to diff View file
A plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactForwardLinksRetrieverTest.php +208 −0 Go to diff View file
M plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksByChangesetCacheTest.php +3 −4 Go to diff View file
M plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksDiffTest.php +20 −28 Go to diff View file
M plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksFieldUpdateValueBuilderTest.php +60 −45 Go to diff View file
A plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksFieldUpdateValueFormatterTest.php +129 −0 Go to diff View file
A plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksFieldUpdateValueTest.php +78 −0 Go to diff View file
M plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksPayloadExtractorTest.php +13 −8 Go to diff View file
M plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactParentLinkPayloadExtractorTest.php +3 −5 Go to diff View file
D plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/UpdateValue/CollectionOfArtifactLinksInfoTest.php +0 −52 Go to diff View file
M plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/UpdateValue/CollectionOfArtifactLinksTest.php +8 −6 Go to diff View file
A plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/UpdateValue/StoredLinkTest.php +86 −0 Go to diff View file