stable
Clone or download
Read-only
part of request #22231 Decrease adapter responsibility No functional change expected when creating mirror program increments. You can use cypress tests for non-regression. Notes: - There is no need for an adapter here, the artifact link value object build is a pure function, without side effects. It should be in the Domain. - I took the opportunity to introduce builders for our complicated objects like ReplicationData and SourceChangesetValuesCollection. In next contributions, more "Values" will be built with a static method and we will need ReplicationData to build them. Change-Id: I4f1213dde3752fd8cd8fa1de8e05cb2fe107df52
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/TaskBuilder.php | +1 | −3 | Go to diff View file |
| D | plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/ArtifactLinkValueAdapter.php | +0 | −35 | Go to diff View file |
| M | plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/SourceChangesetValuesCollectionAdapter.php | +9 | −15 | Go to diff View file |
| M | plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Source/Changeset/Values/ArtifactLinkValue.php | +11 | −5 | Go to diff View file |
| M | plugins/program_management/tests/unit/Adapter/Program/Backlog/AsynchronousCreation/CreateProgramIncrementsTaskTest.php | +5 | −54 | Go to diff View file |
| M | plugins/program_management/tests/unit/Adapter/Program/Backlog/AsynchronousCreation/StatusValueMapperTest.php | +3 | −37 | Go to diff View file |
| M | plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/ArtifactCreatorAdapterTest.php | +4 | −1 | Go to diff View file |
| D | plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/ArtifactLinkValueAdapterTest.php | +0 | −61 | Go to diff View file |
| A | plugins/program_management/tests/unit/Builder/ReplicationDataBuilder.php | +60 | −0 | Go to diff View file |
| A | plugins/program_management/tests/unit/Builder/SourceChangesetValuesCollectionBuilder.php | +131 | −0 | Go to diff View file |
| M | plugins/program_management/tests/unit/Domain/Program/Backlog/AsynchronousCreation/ProgramIncrementsCreatorTest.php | +3 | −34 | Go to diff View file |
| R | plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Source/Changeset/Values/BuildArtifactLinkValue.php | Go to diff View file | ||
| M | plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramIncrement/Source/Fields/ProgramIncrementFieldsDataTest.php | +4 | −50 | Go to diff View file |