part story #32280 Complete the "move artifact" feature The methods inside MoveChangesetXMLDuckTypingUpdater were too complex: - Nested loops - Nested if blocks - No usage of the early return pattern It should be easier to understand what it does now. [bonus] I've optimized a few portions of code: 1. We don't iterate over the "not migrateable fields" list anymore for each field change in each chageset in order to know wether we should delete the XML node or we should update it. Now we build a simple list of fields names and verify that the current field name does not appear in this list. 2. To find the destination field in the collection of FieldsMapping, we now make the comparison based on the field name, and not a deep object equality anymore. -- no functional change expectd. Unit test should pass successfully. Change-Id: Ibf48d74611ac5aace9734801b720cdb70fee583b

+44 −21

Author

Thomas Gorka (tgorka) 2023-06-14 15:06

Committer

Thomas Gorka (tgorka) 2023-06-14 17:01

Hash e8af1159366a09388ce2019af34c95da1b819f8f

Parent 1629489ddb1a8a7a2c64d64f36e572e7b242f770

Reference git #tuleap/stable/e8af1159366a09388ce2019af34c95da1b819f8f