stable
Clone or download
Read-only
request #23379 I can bypass the creation check for Program increments
This patch only deal with Program Increment Iteration will be handle in dedicated patchset Given I am a project member of the Program but I am not project member of one of the Teams, when I click on "New program increment", I don't see an error and I am redirected to artifact creation view. I should have seen an error telling me I don't have permission to create a new program increment. This issue also appears for Iterations (when active with the feature flag). The logs show that the code cannot retrieve the top planning of the project I am not member of. The error log is written but the "submit" button is not disabled. Change-Id: Ifb0da7c188c979bea58ff51257ee0f2dbecdc110
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/program_management/include/Adapter/Program/PlanningAdapter.php | +10 | −3 | Go to diff View file |
| M | plugins/program_management/include/Domain/Program/Admin/Configuration/ConfigurationErrorsCollector.php | +21 | −1 | Go to diff View file |
| A | plugins/program_management/include/Domain/Program/Admin/Configuration/TeamHasNoRootPlanningPresenter.php | +41 | −0 | Go to diff View file |
| M | plugins/program_management/include/Domain/Program/Admin/Configuration/TrackerErrorPresenter.php | +13 | −3 | Go to diff View file |
| M | plugins/program_management/include/Domain/Program/Backlog/AsynchronousCreation/ProgramIncrementCreationProcessor.php | +4 | −5 | Go to diff View file |
| M | plugins/program_management/include/Domain/Program/Backlog/CreationCheck/ProgramIncrementCreatorChecker.php | +15 | −5 | Go to diff View file |
| M | plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/PlanningHasNoProgramIncrementException.php | +1 | −1 | Go to diff View file |
| M | plugins/program_management/include/Domain/Program/Backlog/TrackerCollection.php | +13 | −4 | Go to diff View file |
| M | plugins/program_management/include/Domain/Team/MirroredTimebox/RetrievePlanningMilestoneTracker.php | +2 | −3 | Go to diff View file |
| M | plugins/program_management/site-content/fr_FR/LC_MESSAGES/tuleap-program_management.po | +8 | −0 | Go to diff View file |
| M | plugins/program_management/templates/admin/admin.mustache | +2 | −0 | Go to diff View file |
| A | plugins/program_management/templates/admin/configuration-errors/team-errors.mustache | +10 | −0 | Go to diff View file |
| M | plugins/program_management/tests/unit/Adapter/Admin/Configuration/ConfigurationErrorsCollectorTest.php | +7 | −0 | Go to diff View file |
| M | plugins/program_management/tests/unit/Adapter/Program/Backlog/CreationCheck/RequiredFieldCheckerTest.php | +6 | −6 | Go to diff View file |
| M | plugins/program_management/tests/unit/Adapter/Program/Backlog/CreationCheck/SemanticCheckerTest.php | +1 | −1 | Go to diff View file |
| M | plugins/program_management/tests/unit/Adapter/Program/Backlog/CreationCheck/StatusSemanticCheckerTest.php | +1 | −1 | Go to diff View file |
| M | plugins/program_management/tests/unit/Adapter/Program/Backlog/CreationCheck/WorkflowCheckerTest.php | +5 | −5 | Go to diff View file |
| M | plugins/program_management/tests/unit/Adapter/Program/PlanningAdapterTest.php | +20 | −1 | Go to diff View file |
| M | plugins/program_management/tests/unit/Domain/Program/Backlog/AsynchronousCreation/ProgramIncrementsCreatorTest.php | +3 | −1 | Go to diff View file |
| M | plugins/program_management/tests/unit/Domain/Program/Backlog/CreationCheck/ProgramIncrementCreatorCheckerTest.php | +0 | −3 | Go to diff View file |
| M | plugins/program_management/tests/unit/Domain/Program/Backlog/CreationCheck/TimeboxCreatorCheckerTest.php | +2 | −1 | Go to diff View file |
| M | plugins/program_management/tests/unit/Domain/Program/Backlog/Source/SourceTrackerCollectionTest.php | +3 | −1 | Go to diff View file |
| M | plugins/program_management/tests/unit/Domain/Program/Backlog/TrackerCollectionTest.php | +3 | −3 | Go to diff View file |
| M | plugins/program_management/tests/unit/Stub/RetrievePlanningMilestoneTrackerStub.php | +3 | −3 | Go to diff View file |