Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: use orElse() to create an integration

Download Browse

Part of story #26799 associate a Tuleap project and a GitLab group No functional change expected in synchronize REST route or POST gitlab_groups REST route. orElse() is meant to try to recover from an error. Here, we try to retrieve a repository integration for a given Tuleap Project and GitLab Project. We don't know if it exists; if it doesn't, it's ok, we will just create it. It is a good use case for orElse() because when the integration does not exist, it's perfectly normal, it just means we need to create it. In either case, we will then link the integration (new or existing) to our GroupLink. Change-Id: Id0b5209c64aa96e4f106c6527da20e92b2911cfe

+51 −51
Joris MASSON (jmasson) 2022-10-19 18:29
Joris MASSON (jmasson) 2022-10-20 10:10
ee37ea02c1dff7178dbe99266bc6f76dcb3efad1
86f7425e4051afd71f5fb4b914ec4c942e24d970
git #tuleap/stable/ee37ea02c1dff7178dbe99266bc6f76dcb3efad1

Modified Files

Side by side diff
Inline diff
Name
M plugins/gitlab/include/Repository/GitlabProjectIntegrator.php +45 −38 Go to diff View file
M plugins/gitlab/tests/unit/Repository/GitlabProjectIntegratorTest.php +6 −13 Go to diff View file