stable

Clone or download

Read-only

request #22615 Transition rule for add to top backlog can fail

Introduced by 277446571faba213518c95f6be1dd457d83209f4 How to test: - Disallow anonymous user in site administration access. - In a plannable tracker in a Program project, edit the workflow transitions. Add an "Add to top backlog" post action in any transition. Save it and open the same transition again. The post action should be saved and loaded correctly. - No functional change expected when planning a feature with mass change, drag and drop in Program or drag and drop in kanban with the workflow enabled. - No functional change expected in the rest of Program Management. Notes: - Entry point is in TopBacklogChangeProcessor - The "Bypass" is a nullable and not a boolean so we can describe why it exists. For now, we don't need to do anything with it so it's empty. Change-Id: Ifb4b2ff7bedb5941ff8f423c9625f1f7ba9f098d

Modified Files

Name
A plugins/program_management/include/Adapter/Permissions/WorkflowUserPermissionBypass.php +34 −0 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/TopBacklog/ArtifactTopBacklogActionBuilder.php +0 −2 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/TopBacklog/MassChangeTopBacklogActionBuilder.php +0 −2 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/TopBacklog/MassChangeTopBacklogActionProcessor.php +1 −1 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/TopBacklog/ProcessTopBacklogChange.php +13 −10 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/TopBacklog/Workflow/AddToTopBacklogPostAction.php +9 −2 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/TopBacklog/Workflow/AddToTopBacklogPostActionFactory.php +2 −1 Go to diff View file
M plugins/program_management/include/Adapter/Program/Feature/VerifyIsVisibleFeatureAdapter.php +11 −2 Go to diff View file
M plugins/program_management/include/Adapter/Program/Plan/ProgramAdapter.php +8 −7 Go to diff View file
D plugins/program_management/include/Adapter/Workspace/UserPermissionsProxy.php +0 −60 Go to diff View file
R plugins/program_management/include/Domain/Workspace/UserPermissions.php Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/Feature/FeatureIdentifier.php +4 −2 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/Feature/VerifyIsVisibleFeature.php +7 −1 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Content/ContentModifier.php +0 −2 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/TopBacklog/TopBacklogChangeProcessor.php +7 −1 Go to diff View file
M plugins/program_management/include/Domain/Program/Plan/BuildProgram.php +2 −1 Go to diff View file
M plugins/program_management/include/Domain/Program/Plan/PrioritizeFeaturesPermissionVerifier.php +12 −5 Go to diff View file
M plugins/program_management/include/Domain/Program/Plan/VerifyPrioritizeFeaturesPermission.php +6 −2 Go to diff View file
M plugins/program_management/include/Domain/Program/ProgramIdentifier.php +8 −3 Go to diff View file
M plugins/program_management/include/Domain/UserCanPrioritize.php +4 −4 Go to diff View file
M plugins/program_management/include/REST/v1/ProjectResource.php +2 −1 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/Content/FeatureAdditionProcessorTest.php +0 −3 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/Content/FeatureRemovalProcessorTest.php +1 −2 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/TopBacklog/ProcessTopBacklogChangeTest.php +15 −13 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Feature/VerifyIsVisibleFeatureAdapterTest.php +83 −30 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Plan/PrioritizeFeaturesPermissionVerifierTest.php +40 −79 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Plan/ProgramAdapterTest.php +46 −25 Go to diff View file
D plugins/program_management/tests/unit/Adapter/Workspace/UserPermissionsProxyTest.php +0 −77 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/Feature/FeatureIdentifierTest.php +36 −8 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramIncrement/Content/ContentModifierTest.php +1 −1 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramIncrement/Content/FeatureAdditionTest.php +41 −23 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramIncrement/Content/FeatureRemovalTest.php +30 −14 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/ProgramIdentifierTest.php +17 −4 Go to diff View file
M plugins/program_management/tests/unit/Stub/BuildProgramStub.php +13 −26 Go to diff View file
D plugins/program_management/tests/unit/Stub/UserPermissionsStub.php +0 −64 Go to diff View file
M plugins/program_management/tests/unit/Stub/VerifyIsVisibleFeatureStub.php +8 −3 Go to diff View file
M plugins/program_management/tests/unit/Stub/VerifyPrioritizeFeaturesPermissionStub.php +6 −3 Go to diff View file
M plugins/program_management/tests/unit/UserCanPrioritizeTest.php +6 −6 Go to diff View file