stable

Clone or download

Read-only

refactor: Move LinkFieldController to Domain

No functional change expected in the Artifact link field behaviour in the Artifact modal. Notes: As it holds the most business logic, the Controller should be in the Domain, not in the UI adapter. It should only handle Domain objects, not presenters. Its job is to know everything the links field can do: how to mark links for removal, how to retrieve existing links, how to add new ones, how to retrieve possible parents, etc. part of request #32274 Simplify Artifact link field Change-Id: If2c0ca6823c280464290d9763156f50191f76dce

Modified Files

Name
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/CollectionOfAllowedLinksTypesPresenters.test.ts +3 −4 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/CollectionOfAllowedLinksTypesPresenters.ts +2 −3 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/LinkField.test.ts +53 −45 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/LinkField.ts +64 −39 Go to diff View file
D plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/LinkFieldController.ts +0 −219 Go to diff View file
D plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/LinkFieldPresenter.test.ts +0 −40 Go to diff View file
D plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/LinkFieldPresenter.ts +0 −32 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/LinkTypeSelectorElement.test.ts +3 −4 Go to diff View file
D plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/LinkedArtifactCollectionPresenter.test.ts +0 −58 Go to diff View file
D plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/LinkedArtifactCollectionPresenter.ts +0 −48 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/LinkedArtifactTemplate.test.ts +26 −13 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/LinkedArtifactTemplate.ts +13 −13 Go to diff View file
D plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/NewLinkCollectionPresenter.ts +0 −27 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/NewLinkTemplate.test.ts +5 −5 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/dropdown/ArtifactLinkSelectorAutoCompleter.test.ts +4 −3 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/Field.ts +5 −1 Go to diff View file
D plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/link-field/ArtifactLinkFieldInfo.ts +0 −30 Go to diff View file
R plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/LinkFieldController.test.ts Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/link-field/LinkFieldController.ts +195 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/tuleap-artifact-modal-controller.js +1 −1 Go to diff View file
R plugins/tracker/scripts/lib/artifact-modal/tests/stubs/ArtifactLinkFieldInfoStub.ts Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/tests/stubs/VerifyHasParentLinkStub.ts +0 −4 Go to diff View file