stable

Clone or download

Read-only

Add missing interfaces, artifact should be manipulate over replication data

part of story #17878 rename Multi Project Backlog into Scaled Agile No functional changes: - In administration, release aggregator planning is still available - Creating a release cretae project increment in team projects I consider this task should close the story: Now we have Data object who provides us only what we need in plugin Everytime it's possible the Data object must be declared as final/immutable or read only I had to keep full objects for some case (changeset, fields and tracker), when theses full objects are needed in code, they must be accessed only over Data object. Change-Id: I7a2eb36ac98b02d0966ae606ce428d2ef7495fd2

Modified Files

Name
M plugins/scaled_agile/include/Program/Administration/PlannableItems/PlannableItems.php +15 −18 Go to diff View file
M plugins/scaled_agile/include/Program/Administration/PlannableItems/PlannableItemsCollectionBuilder.php +18 −14 Go to diff View file
M plugins/scaled_agile/include/Program/Administration/PlannableItems/PlannableItemsTrackersUpdater.php +2 −2 Go to diff View file
M plugins/scaled_agile/include/Program/Administration/PlannableItems/Presenter/PlannableItemsPerTeamPresenterCollectionBuilder.php +5 −5 Go to diff View file
M plugins/scaled_agile/include/Program/Administration/ProgramAdminPresenter.php +4 −4 Go to diff View file
M plugins/scaled_agile/include/Program/Administration/ReadOnlyProgramAdminURLBuilder.php +7 −17 Go to diff View file
M plugins/scaled_agile/include/Program/Administration/ReadOnlyProgramAdminViewController.php +22 −7 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/AsynchronousCreation/ArtifactCreatedHandler.php +5 −7 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/AsynchronousCreation/CreateProgramIncrementsTask.php +14 −28 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/AsynchronousCreation/CreateProjectIncrementsRunner.php +28 −60 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/AsynchronousCreation/ProjectIncrementsCreator.php +1 −1 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/AsynchronousCreation/StatusValueMapper.php +1 −1 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/CreationCheck/ArtifactCreatorChecker.php +5 −4 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/CreationCheck/ProjectIncrementArtifactCreatorChecker.php +4 −4 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/CreationCheck/RequiredFieldChecker.php +2 −2 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/CreationCheck/StatusSemanticChecker.php +3 −3 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/ProjectIncrement/Project/TeamProjectsCollection.php +7 −10 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/ProjectIncrement/Project/TeamProjectsCollectionBuilder.php +10 −11 Go to diff View file
A plugins/scaled_agile/include/Program/Backlog/ProjectIncrement/Source/ArtifactData.php +54 −0 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/ProjectIncrement/Source/Changeset/Values/ArtifactLinkValueAdapter.php +4 −4 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/ProjectIncrement/Source/Changeset/Values/ArtifactLinkValueData.php +1 −1 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/ProjectIncrement/Source/Changeset/Values/DescriptionValueAdapter.php +6 −7 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/ProjectIncrement/Source/Changeset/Values/EndPeriodValueAdapter.php +6 −7 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/ProjectIncrement/Source/Changeset/Values/SourceChangesetValuesCollectionAdapter.php +12 −13 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/ProjectIncrement/Source/Changeset/Values/StartDateValueAdapter.php +5 −4 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/ProjectIncrement/Source/Changeset/Values/StatusValueAdapter.php +5 −4 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/ProjectIncrement/Source/Changeset/Values/TitleValueAdapter.php +5 −4 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/ProjectIncrement/Source/Fields/FieldArtifactLinkAdapter.php +6 −4 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/ProjectIncrement/Source/Fields/FieldData.php +1 −1 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/ProjectIncrement/Source/Fields/FieldDescriptionAdapter.php +6 −4 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/ProjectIncrement/Source/Fields/FieldStatusAdapter.php +6 −4 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/ProjectIncrement/Source/Fields/FieldTitleAdapter.php +7 −5 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/ProjectIncrement/Source/Fields/FieldsTimeFrameAdapter.php +6 −4 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/ProjectIncrement/Source/Fields/SynchronizedFieldDataFromProgramAndTeamTrackers.php +1 −1 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/ProjectIncrement/Source/Fields/SynchronizedFieldsAdapter.php +3 −1 Go to diff View file
A plugins/scaled_agile/include/Program/Backlog/ProjectIncrement/Source/ReplicationData.php +92 −0 Go to diff View file
A plugins/scaled_agile/include/Program/Backlog/ProjectIncrement/Source/ReplicationDataAdapter.php +118 −0 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/ProjectIncrement/Source/SourceTrackerCollection.php +8 −6 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/ProjectIncrement/Tracker/ProjectIncrementsTrackerCollection.php +12 −10 Go to diff View file
M plugins/scaled_agile/include/Program/Backlog/TrackerCollectionFactory.php +5 −8 Go to diff View file
M plugins/scaled_agile/include/Program/PlanningConfiguration/PlanningAdapter.php +15 −4 Go to diff View file
M plugins/scaled_agile/include/Program/PlanningConfiguration/PlanningData.php +19 −5 Go to diff View file
A plugins/scaled_agile/include/ProjectData.php +64 −0 Go to diff View file
A plugins/scaled_agile/include/ProjectDataAdapter.php +50 −0 Go to diff View file
A plugins/scaled_agile/include/TrackerData.php +77 −0 Go to diff View file
A plugins/scaled_agile/include/TrackerDataAdapter.php +53 −0 Go to diff View file
A plugins/scaled_agile/include/TrackerNotFoundException.php +33 −0 Go to diff View file
M plugins/scaled_agile/include/scaled_agilePlugin.php +28 −20 Go to diff View file
M plugins/scaled_agile/site-content/fr_FR/LC_MESSAGES/tuleap-scaled_agile.po +3 −0 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Administration/PlannableItems/PlannableItemsCollectionBuilderTest.php +71 −37 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Administration/PlannableItems/PlannableItemsTrackersUpdaterTest.php +37 −19 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Administration/PlannableItems/Presenter/PlannableItemsPerTeamPresenterCollectionBuilderTest.php +35 −24 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Administration/ReadOnlyProgramAdminURLBuilderTest.php +51 −33 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Administration/ReadOnlyProgramAdminViewControllerTest.php +62 −51 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Backlog/AsynchronousCreation/ArtifactCreatedHandlerTest.php +41 −32 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Backlog/AsynchronousCreation/CreateProgramIncrementsTaskTest.php +76 −58 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Backlog/AsynchronousCreation/CreateProjectIncrementsRunnerTest.php +31 −130 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Backlog/AsynchronousCreation/ProjectIncrementCreatorTest.php +15 −13 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Backlog/CreationCheck/ArtifactCreatorCheckerTest.php +32 −22 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Backlog/CreationCheck/ProjectIncrementArtifactCreatorCheckerTest.php +111 −81 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Backlog/CreationCheck/RequiredFieldCheckerTest.php +5 −2 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Backlog/CreationCheck/SemanticCheckerTest.php +77 −23 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Backlog/CreationCheck/StatusSemanticCheckerTest.php +34 −8 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Backlog/CreationCheck/WorkflowCheckerTest.php +4 −3 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Backlog/ProjectIncrement/Project/TeamProjectsCollectionBuilderTest.php +12 −10 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Backlog/ProjectIncrement/Project/TeamProjectsCollectionTest.php +3 −2 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Backlog/ProjectIncrement/Source/Changeset/Values/ArtifactLinkValueAdapterTest.php +23 −3 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Backlog/ProjectIncrement/Source/Changeset/Values/DescriptionValueAdapterTest.php +27 −2 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Backlog/ProjectIncrement/Source/Changeset/Values/EndPeriodValueAdapterTest.php +33 −6 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Backlog/ProjectIncrement/Source/Changeset/Values/StartDateValueAdapterTest.php +27 −2 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Backlog/ProjectIncrement/Source/Changeset/Values/StatusValueAdapterTest.php +27 −2 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Backlog/ProjectIncrement/Source/Changeset/Values/SynchronizedFieldCollectionBuilderTest.php +3 −2 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Backlog/ProjectIncrement/Source/Changeset/Values/TimeframeFieldsTest.php +6 −6 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Backlog/ProjectIncrement/Source/Changeset/Values/TitleValueAdapterTest.php +32 −3 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Backlog/ProjectIncrement/Source/Fields/FieldArtifactLinkAdapterTest.php +6 −5 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Backlog/ProjectIncrement/Source/Fields/FieldDescriptionAdapterTest.php +6 −5 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Backlog/ProjectIncrement/Source/Fields/FieldStatusAdapterTest.php +6 −5 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Backlog/ProjectIncrement/Source/Fields/FieldTitleAdapterTest.php +13 −12 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Backlog/ProjectIncrement/Source/Fields/FieldsTimeFrameAdapterTest.php +14 −13 Go to diff View file
A plugins/scaled_agile/tests/unit/Program/Backlog/ProjectIncrement/Source/ReplicationDataAdapterTest.php +156 −0 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Backlog/ProjectIncrement/Source/SourceTrackerCollectionTest.php +7 −2 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Backlog/ProjectIncrement/Tracker/ProjectIncrementsTrackerCollectionTest.php +7 −2 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/Backlog/TrackerCollectionFactoryTest.php +71 −36 Go to diff View file
M plugins/scaled_agile/tests/unit/Program/PlanningConfiguration/PlanningAdapterTest.php +20 −4 Go to diff View file