No changes have been made to the API, all existing methods without an explicit visibility has been set to the equivalent 'public' visibility. The change has been fully automated by making the sniff fixable temporarily using the following patch: --- a/src/Standards/Squiz/Sniffs/Scope/MethodScopeSniff.php +++ b/src/Standards/Squiz/Sniffs/Scope/MethodScopeSniff.php @@ -64,12 +64,18 @@ class MethodScopeSniff extends AbstractScopeSniff } } + $fix = false; if ($modifier === null) { $error = 'Visibility must be declared on method "%s"'; $data = [$methodName]; - $phpcsFile->addError($error, $stackPtr, 'Missing', $data); + $fix = $phpcsFile->addFixableError($error, $stackPtr, 'Missing', $data); } + if ($fix) { + $phpcsFile->fixer->beginChangeset(); + $phpcsFile->fixer->addContentBefore($stackPtr, 'public '); + $phpcsFile->fixer->endChangeset(); + } }//end processTokenWithinScope() Change-Id: I2a0f3e50fbe9d893678fb39108a68e82ad44829f

+8004 −8005

Author

Thomas Gerbet (tgerbet) 2020-02-15 17:15

Committer

Thomas Gerbet (tgerbet) 2020-02-17 23:12

Hash f1cd5e9a817a4081bc97f0edba05f3b1f006a89a

Parent 3ad8af457b9c7e22474f6cc696a7321f974dd4a0

Reference git #tuleap/stable/f1cd5e9a817a4081bc97f0edba05f3b1f006a89a