Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: refactor PullRequestCommentPresenter

Download Browse

part of story #29240 reply to pull request comment What have been done: - The file have been renamed to PullRequestCommentPresenter to match the case used by every files in the /comments folder. - Interfaces regarding the presenter of the comment have been moved to PullRequestCommentPresenter to unclutter PullRequestComment.ts - We now have static methods to build the presenter from different payloads. This way, we do not have to pass a State object, unless we actually need it to build urls. - Payloads attributes has been set to readonly as they are never supposed to be mutated. - We now stictly inject in the presenter what's needed by the custom element, instead of injecting everything else contained in the payload. It will allow us to know better what we have in the presenters. Please note that the interface PullRequestInlineCommentPresenter seems unused, but it is needed to keep the app working, as the file diff needs the attributes defined in it to work. No functional change expected Change-Id: Icca93b547515f5902fd2407d036ddf43eb3204cd

+14 −63
Thomas Gorka (tgorka) 2022-11-02 17:07
Thomas Gorka (tgorka) 2022-11-02 17:15
f92ee6301505f904a231289d84291b7d96e4d1f3
67e0afd57bbdcb39a21f0112a56d7a1e44efb8d5
git #tuleap/stable/f92ee6301505f904a231289d84291b7d96e4d1f3

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestComment.ts +1 −26 Go to diff View file
R plugins/pullrequest/scripts/pullrequests-app/src/app/comments/pullrequest-comment-presenter-builder.test.ts Go to diff View file
R plugins/pullrequest/scripts/pullrequests-app/src/app/comments/pullrequest-comment-presenter-builder.ts Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/codemirror-helper-service.js +2 −2 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/file-diff-component.js +3 −10 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/overview/timeline/timeline-service.js +5 −23 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/tests/stubs/PullRequestCommentPresenterStub.ts +3 −2 Go to diff View file