Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Remove \XML_Security::loadFile() and \XML_Security::loadString()

Download Browse

PHP 8 deprecates the \libxml_disable_entity_loader() function [0]. Calling XML parsing methods and functions can be considered safe by default, there is no more need to wrap the calls inside another class. So to be sure new usages of this class are not introduced inside the codebase we reduce the exposed API to the bare minimum. Part of request #17931: Unit tests should pass with PHP 8.0 [0] https://github.com/php/php-src/blob/php-8.0.0RC3/UPGRADING#L873 Change-Id: Ic7bc9b45b6c7335205bf503945c026aed22295b8

+10 −58
Thomas Gerbet (tgerbet) 2020-11-02 14:04
Thomas Gerbet (tgerbet) 2020-11-02 14:56
f94d13fedfce3a1a4f7e6c2225e8fc0cf8fdd29c
e20f11129a969b7b55669d75dc38ddeaf21adadc
git #tuleap/stable/f94d13fedfce3a1a4f7e6c2225e8fc0cf8fdd29c

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/Tracker/Artifact/XMLImport.class.php +1 −2 Go to diff View file
M plugins/tracker/include/Tracker/Creation/DefaultTemplatesCollectionBuilder.php +1 −4 Go to diff View file
M plugins/tracker/include/TrackerXmlImport.class.php +4 −3 Go to diff View file
M src/common/CLI/Command/ImportProjectXMLCommand.php +0 −3 Go to diff View file
M src/common/User/XML/Import/UsersToBeImportedCollectionBuilder.php +2 −10 Go to diff View file
M src/common/xml/Security.class.php +0 −28 Go to diff View file
M src/utils/check_user_mapping_for_project_import.php +1 −3 Go to diff View file
M src/utils/generate_user_mapping_for_project_import.php +1 −3 Go to diff View file
M tests/unit/common/User/XML/Import/UsersToBeImportedCollectionBuilderTest.php +0 −2 Go to diff View file