Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Improve drag and drop performances

Download Browse

part of: story #13626 Drag and drop cards This patch improves performances of the dn'd on taskboards having a shitload of cells. To do so, we now avoid to rely on reactive getters in cells: - A class is now directly toggled on cells rejecting the drop -- When the column does not have any mapping for the tracker of the card -- When the user does not have the right to update the mapped field Change-Id: I1d27c432463b18dc72682bb313944a6379d2e5c9

+172 −345
Thomas Gorka (tgorka) 2019-12-04 09:10
Thomas Gorka (tgorka) 2019-12-04 12:44
f9871d40498d78029d4cad4e8c182655de49a9cf
146834b5b61772768a5b4f2fde97aad0ea88abef
git #tuleap/stable/f9871d40498d78029d4cad4e8c182655de49a9cf

Modified Files

Side by side diff
Inline diff
Name
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Cell/CellDisallowsDropOverlay.test.ts +0 −10 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Cell/CellDisallowsDropOverlay.vue +1 −2 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Cell/DropContainerCell.test.ts +2 −21 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Cell/DropContainerCell.vue +4 −23 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/SoloSwimlane.test.ts +1 −2 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/TaskBoard.vue +2 −2 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/helpers/drag-drop.test.ts +27 −5 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/helpers/drag-drop.ts +18 −10 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/helpers/html-to-item.test.ts +10 −10 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/helpers/html-to-item.ts +2 −2 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/store/column/column-getters.test.ts +34 −3 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/store/column/column-getters.ts +12 −2 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/store/swimlane/drag-drop-actions.test.ts +20 −20 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/store/swimlane/drag-drop-actions.ts +5 −5 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/store/swimlane/swimlane-getters.test.ts +1 −166 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/store/swimlane/swimlane-getters.ts +0 −40 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/store/swimlane/swimlane-mutations.ts +21 −14 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/store/swimlane/type.ts +1 −7 Go to diff View file
M plugins/taskboard/themes/includes/_body.scss +10 −0 Go to diff View file
M plugins/taskboard/themes/includes/_card-read.scss +1 −1 Go to diff View file