stable

Clone or download

Read-only

refactor: Baseline Domain should not deal with PFUser

Baseline Domain should not have direct dependency on Tuleap's PFUser class. No functional changes. You can check that deptrac does not raise any errors with the following command: make deptrac SEARCH_PATH=plugins/baseline/tests/deptrac/baseline_domain.yml Note: RoleAssignment has been moved from Adapter to Domain and AuthorizationsImpl from Domain to Adapter Part of story #26359: define dedicated baseline managers Change-Id: I8619add4f4b023ec14a3b730a142c6e3271b6328

Modified Files

Name
A plugins/baseline/include/Adapter/AuthorizationsImpl.php +136 −0 Go to diff View file
M plugins/baseline/include/Adapter/BaselineArtifactRepositoryAdapter.php +18 −22 Go to diff View file
M plugins/baseline/include/Adapter/BaselineRepositoryAdapter.php +19 −8 Go to diff View file
M plugins/baseline/include/Adapter/ComparisonRepositoryAdapter.php +12 −7 Go to diff View file
M plugins/baseline/include/Adapter/CurrentUserProviderAdapter.php +3 −3 Go to diff View file
M plugins/baseline/include/Adapter/ProjectRepositoryAdapter.php +15 −13 Go to diff View file
M plugins/baseline/include/Adapter/RoleAssignmentRepositoryAdapter.php +1 −0 Go to diff View file
A plugins/baseline/include/Adapter/UserProxy.php +42 −0 Go to diff View file
M plugins/baseline/include/Domain/Authorizations.php +8 −10 Go to diff View file
D plugins/baseline/include/Domain/AuthorizationsImpl.php +0 −108 Go to diff View file
M plugins/baseline/include/Domain/Baseline.php +3 −4 Go to diff View file
M plugins/baseline/include/Domain/BaselineArtifactRepository.php +2 −3 Go to diff View file
M plugins/baseline/include/Domain/BaselineArtifactService.php +2 −3 Go to diff View file
M plugins/baseline/include/Domain/BaselineRepository.php +4 −5 Go to diff View file
M plugins/baseline/include/Domain/BaselineService.php +6 −12 Go to diff View file
M plugins/baseline/include/Domain/Comparison.php +3 −4 Go to diff View file
M plugins/baseline/include/Domain/ComparisonRepository.php +4 −6 Go to diff View file
M plugins/baseline/include/Domain/ComparisonService.php +4 −6 Go to diff View file
M plugins/baseline/include/Domain/CurrentUserProvider.php +1 −3 Go to diff View file
M plugins/baseline/include/Domain/ProjectRepository.php +1 −3 Go to diff View file
R plugins/baseline/include/Adapter/RoleAssignment.php Go to diff View file
M plugins/baseline/include/Domain/RoleAssignmentRepository.php +0 −2 Go to diff View file
A plugins/baseline/include/Domain/UserIdentifier.php +28 −0 Go to diff View file
M plugins/baseline/include/REST/BaselineController.php +5 −4 Go to diff View file
M plugins/baseline/include/REST/ComparisonController.php +2 −2 Go to diff View file
M plugins/baseline/include/REST/Exception/ForbiddenRestException.php +1 −1 Go to diff View file
M plugins/baseline/include/REST/Exception/NotFoundRestException.php +1 −1 Go to diff View file
M plugins/baseline/include/Support/ContainerBuilderFactory.php +1 −1 Go to diff View file
A plugins/baseline/tests/deptrac/baseline_domain.yml +10 −0 Go to diff View file
M plugins/baseline/tests/unit/Adapter/ArtifactLinkRepositoryTest.php +8 −8 Go to diff View file
M plugins/baseline/tests/unit/Adapter/BaselineArtifactRepositoryAdapterTest.php +12 −5 Go to diff View file
M plugins/baseline/tests/unit/Adapter/BaselineRepositoryAdapterTest.php +24 −17 Go to diff View file
M plugins/baseline/tests/unit/Adapter/ComparisonRepositoryAdapterTest.php +16 −14 Go to diff View file
M plugins/baseline/tests/unit/Adapter/SemanticValueAdapterFindDescriptionTest.php +4 −4 Go to diff View file
M plugins/baseline/tests/unit/Adapter/SemanticValueAdapterFindInitialEffortTest.php +4 −4 Go to diff View file
M plugins/baseline/tests/unit/Adapter/SemanticValueAdapterFindStatusTest.php +4 −4 Go to diff View file
M plugins/baseline/tests/unit/Adapter/SemanticValueAdapterFindTitleTest.php +4 −4 Go to diff View file
M plugins/baseline/tests/unit/Domain/BaselineArtifactServiceTest.php +7 −10 Go to diff View file
M plugins/baseline/tests/unit/Domain/BaselineServiceTest.php +3 −2 Go to diff View file
M plugins/baseline/tests/unit/Domain/ComparisonServiceTest.php +5 −5 Go to diff View file
M plugins/baseline/tests/unit/Factory/BaselineBuilder.php +3 −3 Go to diff View file
M plugins/baseline/tests/unit/Factory/BaselineFactory.php +3 −2 Go to diff View file
M plugins/baseline/tests/unit/Factory/ComparisonFactory.php +3 −2 Go to diff View file
M plugins/baseline/tests/unit/REST/BaselineArtifactControllerTest.php +5 −2 Go to diff View file
M plugins/baseline/tests/unit/REST/BaselineControllerIntTest.php +1 −1 Go to diff View file
M plugins/baseline/tests/unit/REST/BaselineControllerTest.php +13 −6 Go to diff View file
M plugins/baseline/tests/unit/REST/BaselineRepresentationTest.php +2 −1 Go to diff View file
M plugins/baseline/tests/unit/REST/BaselinesPageRepresentationTest.php +2 −1 Go to diff View file
M plugins/baseline/tests/unit/REST/ComparisonControllerTest.php +5 −2 Go to diff View file
M plugins/baseline/tests/unit/REST/ProjectBaselineControllerIntTest.php +2 −1 Go to diff View file
M plugins/baseline/tests/unit/REST/ProjectBaselineControllerTest.php +4 −2 Go to diff View file
M plugins/baseline/tests/unit/REST/ProjectComparisonControllerIntTest.php +0 −3 Go to diff View file
M plugins/baseline/tests/unit/Stub/BaselineArtifactRepositoryStub.php +3 −3 Go to diff View file
M plugins/baseline/tests/unit/Stub/BaselineRepositoryStub.php +5 −5 Go to diff View file
M plugins/baseline/tests/unit/Stub/ComparisonRepositoryStub.php +5 −5 Go to diff View file
M plugins/baseline/tests/unit/Stub/CurrentUserProviderStub.php +9 −5 Go to diff View file
M plugins/baseline/tests/unit/Stub/FullAccessAuthorizationsStub.php +9 −9 Go to diff View file
M plugins/baseline/tests/unit/Stub/ProjectRepositoryStub.php +2 −2 Go to diff View file
M plugins/baseline/tests/unit/Support/CurrentUserContext.php +9 −6 Go to diff View file