stable

Clone or download

Read-only

DRY core assets

Everywhere in the codebase we can find: ```php new \Tuleap\Layout\IncludeAssets( __DIR__ . '/../../../www/assets/core', '/assets/core' ) ``` In order to avoid guessing what is the right path for assets/core (and to save few keystrokes), we propose to replace the previous instantiation with the following: ```php new \Tuleap\Layout\IncludeCoreAssets() ``` No functional changes. The search and replace used for this changes is based on the following regular expression: `new IncludeAssets\(\s*.*,\s*['"]/assets/core['"]\s*\)` Closes request #20095: Don't Repeat Ourselves with core assets Change-Id: Ice8895f8880410fcd225551c0058fda46726060f

Modified Files

Name
M plugins/agiledashboard/include/AgileDashboard/KanbanJavascriptDependenciesProvider.php +1 −1 Go to diff View file
M plugins/agiledashboard/include/AgileDashboard/Planning/PlanningJavascriptDependenciesProvider.php +1 −1 Go to diff View file
M plugins/document/include/Tree/DocumentTreeController.php +1 −1 Go to diff View file
M plugins/git/include/Git/AdminGerritController.class.php +1 −1 Go to diff View file
M plugins/git/include/Git/AdminMirrorController.class.php +1 −1 Go to diff View file
M plugins/git/include/Git/Repository/GitRepositoryHeaderDisplayerBuilder.php +1 −4 Go to diff View file
M plugins/git/include/GitPHP/controller/Controller_Blame.php +1 −1 Go to diff View file
M plugins/git/include/GitPHP/controller/Controller_Blob.php +1 −4 Go to diff View file
M plugins/git/include/GitPHP/controller/Controller_Tree.php +1 −5 Go to diff View file
M plugins/mediawiki/include/mediawikiPlugin.php +1 −1 Go to diff View file
M plugins/pluginsadministration/include/pluginsadministrationPlugin.php +1 −1 Go to diff View file
M plugins/statistics/include/statisticsPlugin.php +1 −1 Go to diff View file
M plugins/statistics/www/project_over_quota.php +1 −2 Go to diff View file
M plugins/testmanagement/include/testmanagementPlugin.php +1 −4 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Renderer/EditRenderer.class.php +2 −9 Go to diff View file
M src/common/Error/ErrorDependenciesInjector.php +1 −5 Go to diff View file
M src/common/FRS/LicenseAgreement/Admin/AddLicenseAgreementController.php +1 −1 Go to diff View file
M src/common/FRS/LicenseAgreement/Admin/EditLicenseAgreementController.php +1 −1 Go to diff View file
M src/common/FRS/PermissionsPerGroup/PaneCollector.php +1 −5 Go to diff View file
M src/common/MailingList/MailingListAdministrationController.php +1 −2 Go to diff View file
M src/common/MailingList/MailingListHomepageController.php +1 −2 Go to diff View file
M src/common/News/Admin/PermissionsPerGroup/NewsPermissionPerGroupPaneBuilder.php +1 −5 Go to diff View file
M src/common/Password/Administration/PasswordPolicyDisplayController.php +1 −2 Go to diff View file
M src/common/Project/Admin/Categories/IndexController.php +1 −1 Go to diff View file
M src/common/Project/Admin/ProjectDetails/ProjectDetailsController.php +1 −2 Go to diff View file
M src/common/Project/Admin/ProjectMembers/ProjectMembersController.php +1 −2 Go to diff View file
M src/common/Project/Banner/BannerAdministrationController.php +1 −1 Go to diff View file
M src/common/Project/Home.php +1 −5 Go to diff View file
M src/common/Project/Label/IndexController.php +1 −2 Go to diff View file
M src/common/Project/ProjectBackground/ProjectBackgroundAdministrationController.php +1 −1 Go to diff View file
M src/common/Project/Service/IndexController.php +1 −1 Go to diff View file
M src/common/Request/RouteCollector.php +2 −3 Go to diff View file
M src/common/User/Account/DisplayAccountInformationController.php +1 −5 Go to diff View file
M src/common/User/Account/DisplayAppearanceController.php +1 −2 Go to diff View file
M src/common/User/Account/DisplayEditionController.php +1 −2 Go to diff View file
M src/common/User/Account/DisplayKeysTokensController.php +1 −2 Go to diff View file
M src/common/User/Account/DisplaySecurityController.php +1 −2 Go to diff View file
M src/common/User/Account/UserPreferencesHeader.php +1 −2 Go to diff View file
M src/common/Widget/MyProjects.php +1 −2 Go to diff View file
M src/common/Widget/Note/ProjectNote.php +1 −4 Go to diff View file
M src/common/Widget/ProjectContacts.php +1 −2 Go to diff View file
M src/common/Widget/ProjectHeartbeat.php +1 −2 Go to diff View file
M src/common/admin/Homepage/Controller.php +1 −2 Go to diff View file
M src/common/admin/PermissionDelegationController.php +1 −2 Go to diff View file
M src/common/admin/ProjectCreation/ProjectCategoriesDisplayController.php +1 −2 Go to diff View file
M src/common/admin/ProjectCreation/ProjectFieldsDisplayController.php +1 −2 Go to diff View file
M src/common/admin/ProjectCreation/WebhooksDisplayController.php +1 −2 Go to diff View file
M src/common/admin/ProjectWidgetsConfigurationDisplayController.php +1 −2 Go to diff View file
M src/common/date/Admin/RelativeDatesDisplayController.php +1 −2 Go to diff View file
M src/common/date/RelativeDatesAssetsRetriever.php +1 −1 Go to diff View file
M src/common/layout/BaseLayout.php +2 −2 Go to diff View file
A src/common/layout/IncludeCoreAssets.php +34 −0 Go to diff View file
M src/common/layout/Layout.class.php +1 −1 Go to diff View file
M src/themes/BurningParrot/include/BurningParrotTheme.php +1 −2 Go to diff View file
M src/themes/BurningParrot/include/HeaderPresenterBuilder.php +1 −5 Go to diff View file
M src/www/admin/approve_pending_users.php +1 −2 Go to diff View file
M src/www/admin/grouplist.php +1 −2 Go to diff View file
M src/www/admin/index.php +1 −2 Go to diff View file
M src/www/admin/lastlogins.php +1 −2 Go to diff View file
M src/www/admin/massmail.php +1 −2 Go to diff View file
M src/www/admin/projecthistory.php +1 −2 Go to diff View file
M src/www/admin/show_pending_documents.php +1 −5 Go to diff View file
M src/www/admin/system_events/notifications.php +1 −2 Go to diff View file
M src/www/my/index.php +1 −2 Go to diff View file
M src/www/project/admin/editugroup.php +1 −2 Go to diff View file
M src/www/project/admin/ugroup.php +1 −2 Go to diff View file
M src/www/themes/FlamingParrot/FlamingParrot_Theme.class.php +2 −2 Go to diff View file
M src/www/tracker/admin/restore.php +1 −2 Go to diff View file