dev

Forked from tuleap/dev

Clone or download

Read-only

story #2795 - tuleap binded groups to be replicated on Gerrit

The Tuleap binded groups are replicated as Gerrit group of groups aka. included groups. This implies that, on gerrit side, we cannot take into account private projects or restricted users settings into account. Given a "Developers" user group in Tuleap "Top Level" public project And a "Developers" user group in Tuleap "Product" private project, bound to "Top Level/Developers" And "John", member of "Developers", "Top Level" project member but NOT "Product" project member Then John don't have access to any content in "Product" Tuleap project But he has access to Gerrit project that grant access to "Product/Developers" group While this scenario might sounds legit, the behaviour is different and should probably be documented. Change-Id: Iaf380faafcb0221d23c86ba885175a89a716b541

Modified Files

Name
M plugins/git/db/install.sql +9 −2 Go to diff View file
A plugins/git/db/mysql/updates/2013/201304031715_add_gerrit_ugroup_tracking.php +65 −0 Go to diff View file
M plugins/git/db/uninstall.sql +1 −0 Go to diff View file
M plugins/git/include/Git/Driver/Gerrit.class.php +100 −8 Go to diff View file
M plugins/git/include/Git/Driver/Gerrit/MembershipCommand.class.php +13 −24 Go to diff View file
A plugins/git/include/Git/Driver/Gerrit/MembershipCommand/AddBinding.class.php +46 −0 Go to diff View file
M plugins/git/include/Git/Driver/Gerrit/MembershipCommand/AddUser.class.php +8 −7 Go to diff View file
A plugins/git/include/Git/Driver/Gerrit/MembershipCommand/RemoveBinding.class.php +41 −0 Go to diff View file
M plugins/git/include/Git/Driver/Gerrit/MembershipCommand/RemoveUser.class.php +8 −7 Go to diff View file
A plugins/git/include/Git/Driver/Gerrit/MembershipCommand/User.class.php +45 −0 Go to diff View file
A plugins/git/include/Git/Driver/Gerrit/MembershipDao.class.php +39 −0 Go to diff View file
M plugins/git/include/Git/Driver/Gerrit/MembershipManager.class.php +163 −11 Go to diff View file
M plugins/git/include/Git/Driver/Gerrit/ProjectCreator.class.php +14 −23 Go to diff View file
M plugins/git/include/Git/RemoteServer/Dao.class.php +11 −0 Go to diff View file
M plugins/git/include/Git/RemoteServer/GerritServerFactory.class.php +8 −0 Go to diff View file
M plugins/git/include/gitPlugin.class.php +51 −49 Go to diff View file
M plugins/git/tests/Git/Driver/Gerrit/MembershipManagerTest.php +350 −54 Go to diff View file
M plugins/git/tests/Git/Driver/Gerrit/ProjectCreatorTest.php +12 −30 Go to diff View file
M plugins/git/tests/Git/Driver/GerritTest.php +85 −4 Go to diff View file
M src/common/dao/UGroupDao.class.php +4 −4 Go to diff View file
M src/common/event/Event.class.php +23 −0 Go to diff View file
M src/common/project/Admin/UGroup/View/EditBinding.class.php +3 −6 Go to diff View file
M src/common/project/UGroup.class.php +40 −6 Go to diff View file
M src/common/project/UGroupBinding.class.php +5 −8 Go to diff View file
M src/common/project/UGroupManager.class.php +41 −7 Go to diff View file
M tests/bin/simpletest +1 −0 Go to diff View file
M tests/simpletest/common/project/UGroupManagerTest.php +44 −0 Go to diff View file
M tests/simpletest/common/project/UGroupTest.php +31 −0 Go to diff View file
M tools/continuous_integration/ci_build.sh +1 −1 Go to diff View file