Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #10069 Tracker comments don't scale up
    Actions
    Infos
    #10069
    Alexandre Ferrieux (ferrieux)
    2017-09-13 09:32
    2017-03-13 08:31
    10348
    Details
    Tracker comments don't scale up
    Hi,

    In their current implementation, TV5 comments don't scale up beyond a few dozens comments.

    For instance, a 200-comment list takes 10s of server-side latency, and less than 2s for transmission (all in a quick burst at the end) and client-side processing.

    As I assume you guys at Enalean are SQL query optimization experts, I guess there is not much to gain from this angle.

    Now maybe there's another option, which is in line with my earlier remarks about the less-than-obvious expand/collapse tool:

    What about expand-on-demand ?

    The idea is to serve in the main page, not the comments with their full bodies as they are today, but just headers (Author + Date). Each header then displays an Expand link that will go back to the server to fetch the individual comment body. An "Expand All" button can also be imagined, giving the current behavior.

    Reactions ?

    Thanks in advance,

    -Alex
    Trackers
    Empty
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Empty
    Closed
    2017-09-13
    Attachments
    Artifact links

    Releases

    Fixed in

    Artifact ID Project Tracker Summary Status Last Update Date Submitted By Assigned to
    rel #10478 Tuleap Releases 9.11 Delivered 2017-18-08 11:11 Manuel Vacelet (vaceletm)
    Empty
    References
    Referencing request #10069

    Git commit

    tuleap/tuleap/stable

    Keep HTMLPurifier config across call a4b87fa441
    User avatar Manuel Vacelet (vaceletm) , 2017-08-01 11:51
    Inject last comments when viewing artifacts 546271db69
    User avatar Manuel Vacelet (vaceletm) , 2017-08-03 14:48
    Prepare changeset values before iterating on them 11853d3c25
    User avatar Manuel Vacelet (vaceletm) , 2017-08-08 12:14
    Display settings

    Follow-ups

    User avatar
    Manuel Vacelet (vaceletm)2017-09-13 09:32

    Laurence confirmed the perf imporvement following latest deployment. I close this one.

    • Status changed from Waiting for information to Closed
    • Close date changed from 2017-03-13 to 2017-09-13
    User avatar
    Manuel Vacelet (vaceletm)2017-07-21 19:14

    I just published a serie of patch that gives a huge step forward on this:

    The all 3, on a reference artifact of 274 changests, saves:

    • 57% of wall time (9.18s -> 3.93s)
    • 79% of SQL requests (6670 -> 709)

    The number of SQL requests is roughly the same than on an artifact with a few changesets

    • Reported in version cleared values: 9.4
    User avatar
    Alexandre Ferrieux (ferrieux)2017-03-31 15:32
    Just checked internally: normally you have a remote access to our site-wide machine.
    Please check with Christian or Laurence for the details.
    User avatar
    Alexandre Ferrieux (ferrieux)2017-03-14 09:30
    last edited by: Alexandre Ferrieux (ferrieux) 2017-03-14 09:31
    Nothing about redefined log dirs in my.cnf, so I assume they are at the default location.
    I can see many files in /var/log/tuleap , a few of which are world-readable.
    Please specify which one you want (I may be lucky)
    User avatar
    Nicolas Terray (nterray)2017-03-13 09:03
    Please give us the slow query logs generated during the slow page rendering (the location of log files depends on your MySQL configuration, please check /etc/my.cnf file).

    Ideally we would need a blackfire.io profile access.
    • Status changed from New to Waiting for information