Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #11552 Pullrequest file diff must deal with ISO-8859-1 files
    Actions
    Infos
    #11552
    Yannis ROSSETTO (rossettoy)
    2018-05-31 15:23
    2018-05-31 10:58
    11894
    Details
    Pullrequest file diff must deal with ISO-8859-1 files
    Windows encoded files (ISO-8859-1) generates a fatal error in REST because the provided json content is not UTF-8. The diff representation now converts non UTF-8 lines into UTF-8.

    This will certainly not handle all the cases, but it seems to be good enough.
    Pull Request
    All
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Empty
    Closed
    2018-05-31
    Attachments
    Artifact links

    Releases

    Fixed in

    Artifact ID Project Tracker Summary Status Last Update Date Submitted By Assigned to
    rel #11440 Tuleap Releases 10.2 Delivered 2018-14-09 15:23 Manuel Vacelet (vaceletm)
    Empty
    References
    Referencing request #11552

    Git commit

    tuleap/tuleap/stable

    Merge 'gerrit #11523' into stable/master dbb7cd7c68
    User avatar Thomas Gerbet (tgerbet) , 2018-05-31 15:23
    request #11552 Pullrequest file diff must deal with ISO-8859-1 files 0c1622d3f9
    User avatar Yannis ROSSETTO (rossettoy) , 2018-05-31 11:03
    Referenced by request #11552

    Artifact Tracker v5

    rel #11440 10.2

    Other

    gerrit #11523
    Display settings

    Follow-ups

    User avatar
    Thomas Gerbet (tgerbet)2018-05-31 15:23
    Integrated in Tuleap 10.1.99.52.
    • Status changed from Under review to Closed
    • Connected artifacts
    • Close date set to 2018-05-31
    User avatar
    Yannis ROSSETTO (rossettoy)2018-05-31 11:01
    Hello,

    A patch is under review: gerrit #11523
    • Original Submission
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes
    • Status changed from Verified to Under review