Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #12618 Jenkins webhook might fail when the server URL ends with /
    Actions
    Infos
    #12618
    Thomas Gerbet (tgerbet)
    2018-12-13 11:33
    2018-12-12 13:40
    13318
    Details
    Jenkins webhook might fail when the server URL ends with /
    If a user gives an URL ending with a / Tuleap will try to to notify the Jenkins via an URL looking like this https://jenkins.example.com//git/notifyCommit. Due to the // in the URL Jenkins will not apply the same CSRF checks than for https://jenkins.example.com/git/notifyCommit and the notification request can be rejected with a forbidden error.
    Continuous Integration
    Empty
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Empty
    Closed
    2018-12-13
    Attachments
    Artifact links

    Releases

    Fixed in

    Artifact ID Project Tracker Summary Status Last Update Date Submitted By Assigned to
    rel #12403 Tuleap Releases 10.9 Delivered 2019-02-01 21:57 Manuel Vacelet (vaceletm)
    Empty
    References
    Referencing request #12618

    Git commit

    tuleap/tuleap/stable

    Merge commit 'refs/changes/18/13418/1' of ssh://gerrit.tuleap.net:29418/tuleap into HEAD 9ae1e0ed10
    User avatar Yannis ROSSETTO (rossettoy) , 2018-12-13 11:31
    request #12618: Jenkins webhook might fail when the server URL ends with / ad67e75013
    User avatar Thomas Gerbet (tgerbet) , 2018-12-12 14:04
    Referenced by request #12618

    Artifact Tracker v5

    rel #12403 10.9

    Other

    gerrit #13418
    Display settings

    Follow-ups

    User avatar
    Yannis ROSSETTO (rossettoy)2018-12-13 11:33
    Integrated into Tuleap 10.8.99.56
    • Status changed from Under review to Closed
    • Connected artifacts
    • Close date set to 2018-12-13
    User avatar
    Thomas Gerbet (tgerbet)2018-12-12 14:11
    Patch under review here: gerrit #13418.
    • Original Submission
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes
    • Status changed from Under implementation to Under review