•  
      request #14747 Possible misuse of aria-label for tlp-modal-close
    Infos
    #14747
    Nicolas Terray (nterray)
    2020-04-03 08:55
    2020-04-02 10:34
    16018
    Details
    Possible misuse of aria-label for tlp-modal-close

    The Nu HTML Checker complains about usage of aria-label for tlp-modal-close:

    Warning: Possible misuse of aria-label

    <!DOCTYPE html>
    <html lang="en">
    <title>Test</title>
    <div class="tlp-modal-close" data-dismiss="modal" aria-label="Close">
      ×
    </div>
    </html>

    The attribute aria-label should not be used on div element unless it is marked as landmark or widget role. In our case we have a button, therefore the div should have role="button".

    And since it is a button, it should be focusable and should have focus styling.

    UX/UI
    All
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Nicolas Terray (nterray)
    Closed
    2020-04-03
    Attachments
    Empty
    References

    Follow-ups