•  
      request #20573 Stop building condensed stylesheets
    Infos
    #20573
    Thomas Gerbet (tgerbet)
    2021-04-08 14:36
    2021-04-01 09:56
    22160
    Details
    Stop building condensed stylesheets

    As of today to build the stylesheets we need to build N * M different files (where N in the colors and M the density mode) in every parts of Tuleap (tlp "framework", BurningParrot, plugins...) which have a non negligible impact on the build time and is an annoyance for developers due to the amount of boilerplate it requires.

    Since Tuleap does not support IE anymore (request #18451), we can use CSS variables to achieve the same goal. Instead of building each time we need a stylesheet N*M files we can build once and only once N*M stylesheets containing the CSS variables and use only one stylesheet everywhere else.

    This work can (and should) be done on both the colors and the density modes but dealing with the density modes first is easier due to the limited number of impacted variables and it already reduces the number of stylesheets we built by half (we have 2 density modes).

    Other
    Empty
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Thomas Gerbet (tgerbet)
    Closed
    2021-04-08
    Attachments
    Empty
    References
    Referencing request #20573

    Git commit

    tuleap/tuleap/stable

    Stop building the tlp-${color}-condensed stylesheets 714bd34dcf
    Do not build a condensed stylesheet in the SVN plugin 455fc72b7b
    Stop building core BurningParrot condensed stylesheets 18341b4a06
    Stop building the condensed stylesheets in the tracker plugin 1ede85bd3c
    Stop building the condensed stylesheets in the agiledashboard plugin f7a801257a
    Stop building the condensed stylesheets in the document plugin d5caa840fc
    Stop building the condensed stylesheets in the taskboard plugin d96ccaa945
    Stop building the condensed stylesheets in the testplan plugin e163c3dd0c
    Stop building the condensed stylesheets in the program management plugin fc1b7625c8
    Stop building the condensed stylesheets in the project milestones plugin 8a7e586017
    Stop building the condensed stylesheets in the git and pull-request plugin 7ee91be882
    Stop building the condensed stylesheets in forumml plugin e649636fcb
    Stop building the remaining condensed stylesheets e890517736
    Rename class CssAssetWithoutDensityVariants to CssAsset fda8c3730c
    Load the correct stylesheet in the "Documents under review widget" 43a0e9adfd
    request #20968: Textual report export is not formatted correctly 55a18a2827
    Rename class CssAssetWithoutDensityVariants to CssAsset ed4e59112f
    request #20573: Stop building condensed stylesheets a3cb3fad7f
    request #20573: Stop building condensed stylesheets 2c4ec918e0
    Merge "request #20573: Stop building condensed stylesheets" 41c4e5803b

    Follow-ups

    User avatar
    Thomas Gerbet (tgerbet)2021-04-08 11:18

    All work is done, closing.


    • Status changed from Under implementation to Closed
    • Connected artifacts
    • Close date set to 2021-04-08
    User avatar
    Thomas Gerbet (tgerbet)2021-04-01 09:56
    • Original Submission
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes