•  
     
    story #13810 Have an automatic notification to be sent to the user 1 or 2 weeks in advance before suspension
Summary
As a site-admin
Have an automatic notification to be sent to the user 1 or 2 weeks in advance before suspension
So that he can react and, if needed, reconnect to avoid this suspension.
- Only 1 notification is sent.
- No need for the moment to have dedicated interface at site admin level to customize the email template
- The config param for the delay should be customizable from site config, default value is 1 month

Empty
Status
Empty
Done
Development
  • [ ] Does it involves User Interface? 
  • [ ] Are there any mockups?
  • [ ] Are permissions checked?
  • [ ] Does it need Javascript development?
  • [ ] Does it need a forge upgrade bucket?
  • [ ] Does it need to execute things in system events?
  • [ ] Does it impact project creation (templates)?
  • [ ] Is it exploratory?
Empty
Details
#13810
Nouha Terzi (terzino)
2019-11-06 15:06
2019-08-27 16:27
3999

References

Follow-ups

User avatar
last edited by: Houssem Eddine Azzouz (heazzouz) 2019-10-14 10:25

I understand your point of vue. But one might argue that it’s more of a functional and subjective choice for system maintainers that it would be useless to try and notify a user that has never used the platform. Plus, and more importantly, the email template of the user story, clearly states that user has last logged in on X day. So, if we are to consider the two cases, we would need to separate the users when sending the emails, that are to be sent with different texts, or use a more generic email.

Moreover, concerning thefollowing question:

I'm wondering if this query is doing what it's supposed to do.

At least in my case, I configured my platform with:

  • sys_suspend_inactive_accounts_delay = 30
  • sys_suspend_inactive_accounts_notification_delay = 5

I have people with last_access_date before September 16 (today - 30 - 5) and they didn't receive any email. Did I do something wrong in my testing ?

you'll find a visual explanation in the following link user story-13810

 

 

User avatar

Hello,

I write the comment here because it's about the acceptance criteria. In you comment:

After reviewing the query, the conditions aren't the same. The difference between them is that  UserDao::suspendInactiveAccounts suspends user who did not login for a certain period and users that did not login at all. The user story specifies that the alert should only be sent to those whould did not login for a certain period. With regards to moving suspendInactiveAccounts to IdleUsersDao, I would prefer to do it in the next related user story.

I fail to see where here the acceptance criteria specifies that users that never login shouldn't be notified.

And, I really don't understand why they shouldn't be. Could you elaborate ?

On a more general approach, I find it odd that the behaviour should be different between the 2 related queries.

User avatar

As already answered in the review, EasyDB prepared statements makes useless escapeInt


  • So that
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
User avatar

Hi, I have a of questions (for more contextual information, check the following gerrit push Link). Is there an equivalent to the "escapeInt" function that can be used with the new DAO ? 

User avatar
Nouha Terzi (terzino)2019-08-27 16:27
  • I want to
    -I would like an automatic notification to be sent to the user 1 or 2 weeks in advance 
    +Have an automatic notification to be sent to the user 1 or 2 weeks in advance before suspension