Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

  •  
     
    story #21418 close artifacts with Done semantic
Actions
Summary
Empty
close artifacts with Done semantic
Empty

Overview

This story is a follow-up of art #17183. It fine tune the behaviours

Done semantic

As of art #17183, when artifacts are closed by a commit made on GitLab Tuleap will pick the first "Non open" value (as per "Status" semantic).

When there are several closed values, it might not be the best choice (for instance if the first value is "Canceled").

There is a "Done" semantic that should be used for that but this semantic is provided by Agile Dashboard. Hence:

  • Done semantic should be moved to Tracker for broader re-use
  • GitLab integration should use Done semantic

Keywords

The pattern to close should be widen to match GitLab patterns:

  • Close, Closes, Closed, Closing, close, closes, closed, closing
  • Fix, Fixes, Fixed, Fixing, fix, fixes, fixed, fixing
  • Resolve, Resolves, Resolved, Resolving, resolve, resolves, resolved, resolving
  • Implement, Implements, Implemented, Implementing, implement, implements, implemented, implementing

The keyword can be in title or description of commits or merge requests.

Restrict when to close

As per GitLab documentation, the attempt to automatically close

[...] happens when the commit is pushed to a project’s default branch, or when a commit or merge request is merged into it.

Empty
Empty
Status
Empty
Done
Development
  • [ ] Does it involves User Interface? 
  • [ ] Are there any mockups?
  • [ ] Are permissions checked?
  • [ ] Does it need Javascript development?
  • [ ] Does it need a forge upgrade bucket?
  • [ ] Does it need to execute things in system events?
  • [ ] Does it impact project creation (templates)?
  • [ ] Is it exploratory?
Empty
Details
#21418
Manuel Vacelet (vaceletm)
2021-06-23 11:42
2021-05-27 17:16
3787

References
Artifact links
Referencing story #21418

Artifact Tracker v5

epic #14869 GitLab Integration
story #17183 close artifacts from commit messages
rel #20931 12.10

Git commit

tuleap/tuleap/stable

[tech] Unit and REST tests must use self::assert eeb897a66b
User avatar Yannis ROSSETTO (rossettoy) , 2021-05-31 09:19
Closure keyword comparison must be case insensitive 1d38d2dfb0
User avatar Yannis ROSSETTO (rossettoy) , 2021-05-28 09:08
DRY the error handling if there is a REST error. c9566d74fa
User avatar Clarck Robinson (robinsoc) , 2021-05-28 16:38
[feature] Use first Done value in GitLab artifact closure f3b3237542
User avatar Yannis ROSSETTO (rossettoy) , 2021-05-31 15:35
[feature] add some variations of closure keywords 14930d53b9
User avatar Yannis ROSSETTO (rossettoy) , 2021-06-01 14:30
[feature] Add implement closure keywords 677e048d98
User avatar Yannis ROSSETTO (rossettoy) , 2021-06-01 15:04
[tech] Unit tests must use example.com ead73c0979
User avatar Yannis ROSSETTO (rossettoy) , 2021-06-01 15:52
[tech] Upgrade GitLab version deployed by Docker 845f44d14f
User avatar Yannis ROSSETTO (rossettoy) , 2021-06-01 15:59
[feature] Artifact closure must only be done in default branch 527d7cc106
User avatar Yannis ROSSETTO (rossettoy) , 2021-06-02 13:08
[feature] Add information about GitLab usage in Done semantic a3797c3f3a
User avatar Yannis ROSSETTO (rossettoy) , 2021-06-03 14:41
Display settings

Follow-ups

User avatar
Manuel Vacelet (vaceletm)2021-06-01 17:02
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes