Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

  •  
     
    story #29257 have a thread of comments
Actions
Summary
Empty
have a thread of comments
Empty
  1. A first reply to a top level comment creates a Thread. A new color is associated to the thread (the goal is to help to distinguish one thread from another).
    • The color is taken from Tuleap palette
    • Color is persisted and the information is added into the PR comments REST payload (so the colors are the same on overview & change)
    • At the time of writing, the idea is to let the backend pick-up the color based on the number of threads for a PR (ie. the 3rd thread is created, it picks the 3rd color in the list). Random picking can be an alternative but takes less into account potential conflict or "too near" colors. Here's the list of colors:
      • Graffity Yellow
      • Daphne Blue
      • Coral Pink
      • Acid Green
      • Lilac Purple
      • Clockwork Orange
      • Lake Placid Blue
      • Flamingo Pink

Figma: https://www.figma.com/file/it3BHQkoGPDLTPIV8V6i3h/Git---Pull-requests?node-id=978%3A15201&t=I5H8qiRSsDKU1Aaw-1

Empty
Empty
Status
Pull Request
Done
Development
  • [ ] Does it involves User Interface? 
  • [ ] Are there any mockups?
  • [ ] Are permissions checked?
  • [ ] Does it need Javascript development?
  • [ ] Does it need a forge upgrade bucket?
  • [ ] Does it need to execute things in system events?
  • [ ] Does it impact project creation (templates)?
  • [ ] Is it exploratory?
Empty
Details
#29257
Manuel Vacelet (vaceletm)
2022-12-01 10:28
2022-10-26 15:33
3649

References
Artifact links
Referencing story #29257

Artifact Tracker v5

epic #28288 Revamp of Pull Request Comments
rel #29213 14.3
story #13945 Have threaded conversations in Pull Requests

Git commit

tuleap/tuleap/stable

refactor: Use properties to trigger side-effects after render 03bbc61834
User avatar Joris MASSON (jmasson) , 2022-11-17 16:49
Assign a tlp color at new thread creation b3fbe3af9c
User avatar Marie Ange Garnier (marieange) , 2022-11-18 10:21
Apply color in front end app 76030300ac
User avatar Marie Ange Garnier (marieange) , 2022-11-23 13:44
Started threads are not properly determined 841a10d462
User avatar Marie Ange Garnier (marieange) , 2022-11-25 15:46
Display settings

Follow-ups

User avatar
Benjamin Dauton (bdauton_enalean)2022-11-14 15:15
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
User avatar
Benjamin Dauton (bdauton_enalean)2022-11-14 14:58
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes