Manuel Vacelet (vaceletm)2017-02-15 14:03 Please ask for review using the regular process (internal review at ST, publish + review ques), there are to much reviews for us to manage drafts for each and every change.
marouane baini (bainim)2017-02-15 10:22 Hello Manuel, I tried to fix the issue by adding the missing argument and i published a draft. Thank you for your revue. With my Best regards, Marouane.
Manuel Vacelet (vaceletm)2017-02-13 15:26 Unfortunately there is a bug with the news submission that is available in docman (see attached screenshot) Attachments Screenshot from 2017-02-13 15-23-52.png addedBy Manuel Vacelet (vaceletm)(199 kB)Screenshot from 2017-02-13 15-23-52.png
marouane baini (bainim)2017-02-13 12:18 Hello Manuel, I modified the code after your last comment by changing $GLOBALS['...'] and i published a draft Thank you for your revue. With my Best regards, Marouane.
Manuel Vacelet (vaceletm)2017-02-13 11:16 Hello Marouane, That sounds good. I quickly saw the code and that looks OK (FYI, we prefer to use ForgeConfig::get('..') to access configuration variable rather than legacy $GLOBALS['...']. You can publish your draft and ask the review.
marouane baini (bainim)2017-02-10 17:59 Hello Manuel, After your last comments on the request #9822: Hide forum privacy radio buttons for private projects (gerrit https://gerrit.tuleap.net/#/c/7568/) i tried to fix the issue by applying a second condition on the forum creation to check whether the forum introduced is for news or not. this param reside in local.inc and is defined so there'll be no harm checking on it in the forum creation. Well it's up to you ><, i tried to introduce the visible solutions. With my Best regards, Marouane.
marouane baini (bainim)2017-02-06 14:20 Hello Manuel, I fixed the different issues after your last revue and this is the URL of the request #9822: Hide forum privacy radio buttons for private projects in gerrit https://gerrit.tuleap.net/#/c/7568/ Best regards, Marouane.
Manuel Vacelet (vaceletm)2017-02-06 12:11 In this context, I agree that the flag parameter is the way to go.
marouane baini (bainim)2017-02-03 16:49 Hello Manuel, This is the URL of the request #9822: Hide forum privacy radio buttons for private projects in gerrit https://gerrit.tuleap.net/#/c/7568/ Thank you for your revue. Best regards, Marouane.
Manuel Vacelet (vaceletm)2017-02-03 09:46 Hello Marouane, We tend to avoid flag parameters (https://martinfowler.com/bliki/FlagArgument.html) but it really depends of the qualify of the code you are modifying (and here you are in one of the worst part of Tuleap...). Do you have a draft you can share so we can see if there is a better alternative ?
marouane baini (bainim)2017-02-02 12:26 last edited by: marouane baini (bainim) 2017-02-02 12:43 Hello Manuel, We changed the params sent by the news (privacy one), cause the forum and the news use the same method for their creation. to bypass this issue i added a boolean flag which i pass as parameter to make the difference between forum and news. if you want i can create a new method for news but i'll have to duplicate some code in order to do it. it's up to you. waiting for your response. Best regards, Marouane.
Marie Ange Garnier (marieange)2017-02-01 15:50 gerrit #7563 integrated in Tuleap 9.3.99.160 Status changed from Verified to ClosedClose date set to 2017-02-01
Thomas Gerbet (tgerbet)2017-02-01 14:46 To be able to release Tuleap 9.4 without this regression, a revert of the original contribution is under review (gerrit #7563). The original contribution should be reworked and proposed again to review once this issue is properly fixed. Status changed from New to Verified
Manuel Vacelet (vaceletm)2017-02-01 11:44 Marouane, Are you able to fix that today or do we need to pull-out the patch from 9.4 ?