part of story #32316 Update comments The goal of this refactoring is to extract the replies to a comment in a custom element to be reused each time we want to display a reply. We need a separate custom element because we want to be able to edit replies as well as the root comment. Those replies being each one a custom element, they can have their own WritingZone, and thus handle their own edition actions. Without this refactoring, we wouldn't be able to edit multiple comments at the same time in a same thread, and we would have to deal with clumsy detections and warnings (e.g "you cannot edit this comment because you are still editing another comment in the thread"). Weird. Before the refactoring, the replies were displayed by the root comment using a loop and common templates. We had to handle a few cases to make it work, since we had to know which comment was a reply, who wrote it etc. Now, we know we are handling a reply, and that's it. The counterpart of the refactoring, though, is a bit of code duplication here and there. For the moment, let's consider it harmless until I find a solution. How to test: --> No functional change when the feature flag is OFF in both overview and changes panes. --> No functional change when the feature flag is ON in both overview ans changes panes. To activate the feature flag: - tuleap config-set feature_flag_allow_pull_requests_comments_edition 1 Change-Id: Id105b9dbc057893245a8f72202dfabe077c9cfd4

+766 −173

Author

Thomas Gorka (tgorka) 2023-10-17 15:20

Committer

Thomas Gorka (tgorka) 2023-10-18 16:27

Hash 0a62af8f422ab4d039ddda1f6610936239d5708f

Parent d1e080baacc3c434f669cde0ab9e747defa71a9f

Reference git #tuleap/stable/0a62af8f422ab4d039ddda1f6610936239d5708f