Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

  •  
     
    story #32316 Update comments
Actions
Summary
Empty
Update comments
Empty

I can only update my own comments. Keep time tracking of the comment (date / hour of editing)
Only comment done in markdown are editable.
New REST routes should be created :

  • PATCH pull_request_comments/{id}
  • PATCH pull_request_inline_comments/{id}

Front end :

  • new button
  • edit mode with preview table
  • help button

https://www.figma.com/file/it3BHQkoGPDLTPIV8V6i3h/Git---Pull-requests?type=design&mode=design&t=A7cCmb6XRFTv4WUw-1

Notifications:

  • When comment is saved, a notification is sent (as for new comments)
  • Notification subject: same as new comment
  • Notification message:
$AUTHOR updated their comment on #$PR_ID: $PR_SUMMARY

$NEW_COMMENT
Empty
Empty
Status
Pull Request
Done
Development
  • [ ] Does it involves User Interface? 
  • [ ] Are there any mockups?
  • [ ] Are permissions checked?
  • [ ] Does it need Javascript development?
  • [ ] Does it need a forge upgrade bucket?
  • [ ] Does it need to execute things in system events?
  • [ ] Does it impact project creation (templates)?
  • [ ] Is it exploratory?
Empty
Details
#32316
Marie Ange Garnier (marieange)
2023-12-06 09:29
2023-06-19 11:14
35570

References
Artifact links
Referencing story #32316

Artifact Tracker v5

epic #28288 Revamp of Pull Request Comments
story #13947 Have formatting capabilities in Pull Requests
rel #32660 15.3

Git commit

tuleap/tuleap/stable

feat: introduce edit button feature flag 6b1ed6d3fd
User avatar Thomas Gorka (tgorka) , 2023-10-16 15:47
feat: comments representations have a raw_content attribute a2724ed5e0
User avatar Thomas Gorka (tgorka) , 2023-10-18 08:57
refactor: Extract replies as sub elements 0a62af8f42
User avatar Thomas Gorka (tgorka) , 2023-10-18 16:27
refactor: replace threads reply forms with <tuleap-pullrequest-new-comment-form/> cabf5db3f3
User avatar Thomas Gorka (tgorka) , 2023-10-23 15:17
feat: toggle an edition form 58a7eccb91
User avatar Thomas Gorka (tgorka) , 2023-10-23 17:29
Be able to edit a pull request comment via REST route 6abcf65cc1
User avatar Clarck Robinson (robinsoc) , 2023-10-24 13:58
refactor: extract action events from <tuleap-pullrequest-comment/> 7993bbf5eb
User avatar Thomas Gorka (tgorka) , 2023-10-25 14:43
refactor: Retrieve comment with `CommentRetriever` object instead of `Factory` a031d5522d
User avatar Clarck Robinson (robinsoc) , 2023-10-25 15:37
refactor: Interface to retrieve inline comment b2fded73c3
User avatar Joris MASSON (jmasson) , 2023-10-26 18:34
refactor: Pullrequests apps stubs should not be coupled with Jest/Vitest stubs bab3bd5ff3
User avatar Thomas Gorka (tgorka) , 2023-10-26 10:10
refactor: Create dedicated objects to retrieve pull request and pull request with its git reference 4f52e58ea8
User avatar Clarck Robinson (robinsoc) , 2023-11-02 12:43
feat: add a nullable last_edition_date column to comments tables cf8ee2bf04
User avatar Thomas Gorka (tgorka) , 2023-11-02 14:44
refactor: Make CommentRepresentation class immutable d0b57387ec
User avatar Clarck Robinson (robinsoc) , 2023-11-02 15:44
feat: Make checks before editing inline comment 19a302b57a
User avatar Joris MASSON (jmasson) , 2023-11-02 16:01
feat: Save edited inline comment 985baee1a9
User avatar Joris MASSON (jmasson) , 2023-11-03 15:15
chore: Move stubs in the correct folders fe4d6bbee1
User avatar Joris MASSON (jmasson) , 2023-11-06 11:48
feat: Extract cross-refs from new content of inline comment 3ea2e89a33
User avatar Joris MASSON (jmasson) , 2023-11-06 14:28
Returns the CommentRepresentation in PATCH pull_request_comments/:id f8d00e72ec
User avatar Clarck Robinson (robinsoc) , 2023-11-10 15:11
chore: Move stubs and builders in the correct folders ace5479b8e
User avatar Joris MASSON (jmasson) , 2023-11-13 12:54
feat: Extract cross-refs from new content of global comment e227908416
User avatar Clarck Robinson (robinsoc) , 2023-11-13 12:24
feat: Save the last update date of inline comments 357b50b911
User avatar Joris MASSON (jmasson) , 2023-11-14 10:44
refactor: Stop relying on the the god Factory class in PullRequestUpdatedNotificationToProcessBuilder a08febf803
User avatar Clarck Robinson (robinsoc) , 2023-11-14 10:57
chore: Tests for InlineCommentDAO dff7a6b421
User avatar Joris MASSON (jmasson) , 2023-11-14 15:47
refactor: Stop relying on the the god PullRequest/Factory class in new 89e9397ba5
User avatar Clarck Robinson (robinsoc) , 2023-11-15 09:22
refactor: Build InlineComment representations with business objects 21323175d0
User avatar Joris MASSON (jmasson) , 2023-11-15 15:17
Add REST test for pull request comment fc21d94fd0
User avatar Clarck Robinson (robinsoc) , 2023-11-15 15:33
refactor: Have a business object to create inline comments 7d1a644f57
User avatar Joris MASSON (jmasson) , 2023-11-15 16:16
fix: project from source repository should be used when extracting 4aec274623
User avatar Clarck Robinson (robinsoc) , 2023-11-16 16:44
refactor: extract POSTHandler with unit tests 0842845792
User avatar Joris MASSON (jmasson) , 2023-11-16 16:58
Do not return the project id in `CommentRepresentation` d417f1e665
User avatar Clarck Robinson (robinsoc) , 2023-11-17 10:00
refactor: Build inline comment 979cfaf1f6
User avatar Joris MASSON (jmasson) , 2023-11-17 10:46
refactor: InlineCommentRepresentation is mutation-free 9774adfb64
User avatar Joris MASSON (jmasson) , 2023-11-17 10:47
feat: PATCH inline comment returns a representation 407110c310
User avatar Joris MASSON (jmasson) , 2023-11-17 15:36
chore: add REST test for inline comment f33c51ef8c
User avatar Joris MASSON (jmasson) , 2023-11-20 09:12
feat: save edited comments c9183f4bb8
User avatar Thomas Gorka (tgorka) , 2023-11-20 10:22
Return the last edition date in TimelineInlineCommentRepresentation c20f175510
User avatar Clarck Robinson (robinsoc) , 2023-11-20 15:59
Add missing attribute in the `InlineCommentRepresentation` 356833c7a7
User avatar Clarck Robinson (robinsoc) , 2023-11-21 09:48
feat: Check source Git repo exists 8cae14f017
User avatar Joris MASSON (jmasson) , 2023-11-21 10:22
feat: Add git repo ID to error message 0c5bfd023f
User avatar Joris MASSON (jmasson) , 2023-11-21 16:48
feat: Display last edition date 4ab5f16836
User avatar Thomas Gorka (tgorka) , 2023-11-21 15:14
refactor: remove TimelineInlineCommentRepresentation 3d1ff1aed9
User avatar Clarck Robinson (robinsoc) , 2023-11-21 17:21
chore: Tests for CommentDAO 31179e0745
User avatar Joris MASSON (jmasson) , 2023-11-27 17:21
refactor: Option.fromNullable in TypeScript c1f6283e8d
User avatar Joris MASSON (jmasson) , 2023-11-27 14:37
refactor: Use DateTimeImmutable for last edition dates ab7d93517d
User avatar Joris MASSON (jmasson) , 2023-11-28 14:19
Send notification when user edits his comment fd4d3f424c
User avatar Clarck Robinson (robinsoc) , 2023-11-28 17:55
Send notification when user edits his inline comment 8f29bd1cbb
User avatar Clarck Robinson (robinsoc) , 2023-11-29 17:23
refactor: Use DateTimeImmutable for post dates ed76c4c4fd
User avatar Joris MASSON (jmasson) , 2023-11-30 12:35
refactor: Stop relying on the the god PullRequest/Factory class in some 36d6ff3172
User avatar Clarck Robinson (robinsoc) , 2023-11-30 13:54
refactor: Remove HTML from email translated strings in comment 5ab877ff0b
User avatar Clarck Robinson (robinsoc) , 2023-11-30 13:25
refactor: Stop relying on the the god PullRequest/Factory class in new ed52f710ae
User avatar Clarck Robinson (robinsoc) , 2023-11-30 16:14
refactor: Remove HTML from email translated strings (part 2) 42d394dc7f
User avatar Clarck Robinson (robinsoc) , 2023-11-30 17:24
refactor: Remove remaining HTML from email translated strings db7c564fec
User avatar Clarck Robinson (robinsoc) , 2023-12-01 12:24
refactor: CommentCreator class to group DB queries together 6e1607bade
User avatar Joris MASSON (jmasson) , 2023-12-01 12:08
feat: Remove edit comments feature flag 1a664d20d0
User avatar Joris MASSON (jmasson) , 2023-12-01 17:00
refactor: extract POST Handler for comments eb1df4a632
User avatar Joris MASSON (jmasson) , 2023-12-04 12:40
refactor: Have a business object to create comments 502f896502
User avatar Joris MASSON (jmasson) , 2023-12-04 12:44
Display settings

Follow-ups

User avatar
Joris MASSON (jmasson)2023-12-05 11:20
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
  • Is related to
    • Added is Covered by:
User avatar
Joris MASSON (jmasson)2023-11-30 17:36

gerrit #29914 (refactor: Stop relying on the the god PullRequest/Factory class in new ItemLabeledCollector) integrated in Tuleap 15.2.99.149

User avatar
Joris MASSON (jmasson)2023-11-21 11:19
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
User avatar
Manuel Vacelet (vaceletm)2023-11-16 11:35
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
User avatar
Manuel Vacelet (vaceletm)2023-11-16 10:29
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
User avatar
Joris MASSON (jmasson)2023-11-15 14:26

gerrit #29781 (refactor: Stop relying on the the god PullRequest/Factory class in new comment notification) integrated in Tuleap 15.2.99.39

User avatar
Joris MASSON (jmasson)2023-11-14 14:08

gerrit #29770 (refactor: Stop relying on the the god Factory class in PullRequestUpdatedNotificationToProcessBuilder) integrated in Tuleap 15.2.99.26

User avatar
Joris MASSON (jmasson)2023-11-02 14:33

gerrit #29625 (refactor: Create dedicated objects to retrieve pull request and pull request with its git reference) integrated in Tuleap 15.1.99.82

User avatar
Quentin Dehais (qdehais)2023-10-23 11:03
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
User avatar
Joris MASSON (jmasson)2023-10-20 10:01

PUT -> PATCH. We don't want to send everything, just the modified markdown content.

Also, the routes are not nested under /pull_request/{id} anymore. Doing so would require the caller to know the pull request ID, but it's not a necessary information to give. We can retrieve the comment by its ID in the database directly, and from there, we can retrieve its parent pull request, git repository and project. Seeing as we already applied this pattern for many routes (taskboard cards, gitlab groups, kanban items, etc.), it's not shocking to consider the comments and inline comments as "resources" instead of "sub-resources".

  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
User avatar
Thomas Gorka (tgorka)2023-09-13 11:06
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
User avatar
Marie Ange Garnier (marieange)2023-06-19 11:16
  • So that
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
  • Category set to Pull Request