Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

request #11552 Pullrequest file diff must deal with ISO-8859-1 files

Download Browse

Windows encoded files (ISO-8859-1) generates a fatal error in REST because the provided json content is not UTF-8. The diff representation now converts non UTF-8 lines into UTF-8. This will certainly not handle all the cases, but it seems to be good enough. Change-Id: Iade6819f200b6b85ade388b6ade33b836bc2600e

+16 −6
Yannis ROSSETTO (rossettoy) 2018-05-31 11:03
Yannis ROSSETTO (rossettoy) 2018-05-31 11:03
0c1622d3f9d7796e037437193d4d648d7d518167
0700bfbb1eca82cedc1d18004d248bd8b0eb62b3
git #tuleap/stable/0c1622d3f9d7796e037437193d4d648d7d518167

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/include/PullRequest/REST/v1/PullRequestFileUniDiffRepresentation.php +4 −3 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/PullRequestLineUniDiffRepresentation.php +12 −3 Go to diff View file