stable
Clone or download
Read-only
request #14747: Possible misuse of aria-label for tlp-modal-close
The Nu HTML Checker[0] complains about usage of aria-label for tlp-modal-close: > **Warning**: Possible misuse of aria-label ```html <pre><!DOCTYPE html> <html lang="en"> <title>Test</title> <div class="tlp-modal-close" data-dismiss="modal" aria-label="Close"> × </div> </html></pre> ``` The attribute aria-label should not be used on div element unless it is marked as landmark or widget role[1]. In our case we have a button, therefore the div should have role="button". And since it is a button, it should be focusable[2] and should have focus styling[3]. [0] https://validator.w3.org/nu/#textarea [1] https://developer.paciellogroup.com/blog/2017/07/short-note-on-aria-label-aria-labelledby-and-aria-describedby/ [2] https://developer.mozilla.org/en-US/docs/Web/Accessibility/Understanding_WCAG/Keyboard#Interactive_elements_must_be_focusable [3] https://developer.mozilla.org/en-US/docs/Web/Accessibility/Understanding_WCAG/Keyboard#Focusable_element_must_have_focus_styling Change-Id: I14493bd9bebf1544663c64ca16ea79b4c31311c0
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/admindelegation/templates/modal-add-permission.mustache | +2 | −0 | Go to diff View file |
| M | plugins/admindelegation/templates/modal-revoke-permission.mustache | +1 | −1 | Go to diff View file |
| M | plugins/agiledashboard/scripts/kanban/src/app/edit-kanban/edit-kanban.tpl.html | +1 | −1 | Go to diff View file |
| M | plugins/agiledashboard/scripts/kanban/src/app/error-modal/error.tpl.html | +1 | −1 | Go to diff View file |
| M | plugins/agiledashboard/scripts/kanban/src/app/reports-modal/reports-modal.tpl.html | +2 | −0 | Go to diff View file |
| M | plugins/agiledashboard/templates/admin-scrum/admin-planning-deletion.mustache | +1 | −1 | Go to diff View file |
| M | plugins/agiledashboard/templates/admin-scrum/switch-explicit-backlog-usage-modal.mustache | +4 | −1 | Go to diff View file |
| M | plugins/bugzilla_reference/templates/add-reference.mustache | +1 | −1 | Go to diff View file |
| M | plugins/bugzilla_reference/templates/delete-reference.mustache | +2 | −2 | Go to diff View file |
| M | plugins/bugzilla_reference/templates/edit-reference.mustache | +1 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/DragNDrop/ErrorModal.vue | +7 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/FilesUploads/FilesUploadsModal.vue | +7 | −1 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/ModalCommon/ModalHeader.vue | +2 | −0 | Go to diff View file |
| M | plugins/document/scripts/document/components/Folder/ModalDeleteItem/ModalConfirmDeletion.vue | +7 | −1 | Go to diff View file |
| M | plugins/frs/scripts/release-notes/src/file-download/custom-license-modal/custom-license-modal.tpl.html | +1 | −1 | Go to diff View file |
| M | plugins/frs/scripts/release-notes/src/file-download/license-modal/license-modal.tpl.html | +1 | −1 | Go to diff View file |
| M | plugins/git/scripts/repositories/src/components/GitRepositoryCreate.vue | +7 | −1 | Go to diff View file |
| M | plugins/git/templates/admin-plugin-gerrit-modal-delete.mustache | +1 | −1 | Go to diff View file |
| M | plugins/git/templates/admin-plugin-gerrit-modal-edit.mustache | +1 | −1 | Go to diff View file |
| M | plugins/git/templates/admin-plugin-gerrit-server-modal.mustache | +1 | −1 | Go to diff View file |
| M | plugins/git/templates/admin-plugin-list-repositories.mustache | +1 | −1 | Go to diff View file |
| M | plugins/git/templates/admin-plugin-mirror-configuration-modal.mustache | +1 | −1 | Go to diff View file |
| M | plugins/git/templates/admin-plugin-mirror-modal-delete.mustache | +1 | −1 | Go to diff View file |
| M | plugins/git/templates/admin-plugin-mirror-modal-edit.mustache | +1 | −1 | Go to diff View file |
| M | plugins/git/templates/admin-plugin-mirror-modal.mustache | +1 | −1 | Go to diff View file |
| M | plugins/git/templates/repository/fork-button.mustache | +2 | −2 | Go to diff View file |
| M | plugins/ldap/templates/project-members-ldap-link-modal.mustache | +1 | −1 | Go to diff View file |
| M | plugins/ldap/templates/project/ugroup/binding/modal-content.mustache | +1 | −1 | Go to diff View file |
| M | plugins/oauth2_server/templates/accounts-app-revoke-modal.mustache | +2 | −0 | Go to diff View file |
| M | plugins/oauth2_server/templates/app-add-modal.mustache | +2 | −0 | Go to diff View file |
| M | plugins/oauth2_server/templates/app-delete-modal.mustache | +2 | −0 | Go to diff View file |
| M | plugins/openidconnectclient/templates/administration-providers-modal-create-azure.mustache | +2 | −0 | Go to diff View file |
| M | plugins/openidconnectclient/templates/administration-providers-modal-create-generic.mustache | +2 | −0 | Go to diff View file |
| M | plugins/openidconnectclient/templates/administration-providers-modal-delete.mustache | +1 | −1 | Go to diff View file |
| M | plugins/openidconnectclient/templates/administration-providers-modal-update-azure.mustache | +2 | −0 | Go to diff View file |
| M | plugins/openidconnectclient/templates/administration-providers-modal-update-generic.mustache | +2 | −0 | Go to diff View file |
| M | plugins/pluginsadministration/templates/enable-disable-plugin-switch.mustache | +1 | −1 | Go to diff View file |
| M | plugins/pluginsadministration/templates/install-plugin-modal.mustache | +1 | −1 | Go to diff View file |
| M | plugins/pluginsadministration/templates/uninstall-plugin-modal.mustache | +1 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/create-pullrequest-button/src/components/CreatePullrequestErrorModal.vue | +7 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/create-pullrequest-button/src/components/CreatePullrequestModal.vue | +7 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/src/app/error-modal/error-modal.tpl.html | +1 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/src/app/overview/edit-modal/edit-modal.tpl.html | +1 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/src/app/overview/merge-modal/merge-modal.tpl.html | +1 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/src/app/overview/reviewers/update-reviewers-modal/update-reviewers-modal.tpl.html | +1 | −1 | Go to diff View file |
| M | plugins/statistics/templates/disk-quota-warning.mustache | +1 | −1 | Go to diff View file |
| M | plugins/statistics/templates/project-quota-add-modal.mustache | +2 | −2 | Go to diff View file |
| M | plugins/statistics/templates/project-quota-delete-modal.mustache | +2 | −2 | Go to diff View file |
| M | plugins/statistics/templates/project-quota-details-modal.mustache | +2 | −2 | Go to diff View file |
| M | plugins/taskboard/scripts/taskboard/src/components/GlobalError/ErrorModal.vue | +7 | −1 | Go to diff View file |
| M | plugins/taskboard/scripts/taskboard/src/components/GlobalError/__snapshots__/ErrorModal.test.ts.snap | +2 | −0 | Go to diff View file |
| M | plugins/timetracking/scripts/personal-timetracking-widget/src/components/modal/WidgetModalTimes.vue | +7 | −1 | Go to diff View file |
| M | plugins/tracker/scripts/angular-artifact-modal/src/tuleap-artifact-modal.tpl.html | +1 | −1 | Go to diff View file |
| M | plugins/tracker/scripts/workflow-transitions/src/components/Header/ChangeFieldConfirmationModal.vue | +7 | −1 | Go to diff View file |
| M | plugins/tracker/scripts/workflow-transitions/src/components/Header/WorkflowModeSwitchModal.vue | +9 | −1 | Go to diff View file |
| M | plugins/tracker/scripts/workflow-transitions/src/components/TransitionModal/TransitionModal.vue | +7 | −1 | Go to diff View file |
| M | plugins/tracker/templates/siteadmin-config/natures-modal-create.mustache | +1 | −1 | Go to diff View file |
| M | plugins/tracker/templates/siteadmin-config/natures-modal-delete.mustache | +1 | −1 | Go to diff View file |
| M | plugins/tracker/templates/siteadmin-config/natures-modal-edit.mustache | +1 | −1 | Go to diff View file |
| M | plugins/tuleap_synchro/templates/add_new_endpoint.mustache | +1 | −1 | Go to diff View file |
| M | plugins/tuleap_synchro/templates/delete_endpoint.mustache | +1 | −1 | Go to diff View file |
| M | src/common/User/Account/templates/access-keys.mustache | +1 | −1 | Go to diff View file |
| M | src/common/User/Account/templates/account-information.mustache | +1 | −1 | Go to diff View file |
| M | src/common/User/Account/templates/ssh-keys.mustache | +1 | −1 | Go to diff View file |
| M | src/common/User/Account/templates/svn-tokens.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/admin/global-utils/massmail.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/admin/permission_delegation/delete_group_modal.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/admin/permission_delegation/group_modal.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/admin/permission_delegation/permissions_modal.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/admin/projects/add_description_field_modal.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/admin/projects/configuration.mustache | +5 | −5 | Go to diff View file |
| M | src/templates/admin/projects/delete_description_field_modal.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/admin/projects/edit_description_field_modal.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/admin/projects/trovecat-modal-add.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/admin/projects/trovecat-modal-delete.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/admin/projects/trovecat-modal-edit.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/admin/system_events/modal-details-system-event.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/admin/system_events/notifications-add-modal.mustache | +2 | −2 | Go to diff View file |
| M | src/templates/admin/system_events/notifications-delete-modal.mustache | +2 | −2 | Go to diff View file |
| M | src/templates/admin/system_events/notifications-edit-modal.mustache | +2 | −2 | Go to diff View file |
| M | src/templates/admin/trackers/modal-remove-tracker.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/admin/users/user-change-password.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/admin/users/user.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/dashboard/add-dashboard-modal.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/dashboard/add-widget-modal.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/dashboard/delete-dashboard-modal.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/dashboard/delete-widget-modal.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/dashboard/edit-dashboard-modal.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/dashboard/edit-widget-modal.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/error/join-project.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/project/admin/services/services-delete-modal.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/project/admin/ugroup-add-member-modal.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/project/admin/ugroup-settings-binding-modal-add.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/project/admin/ugroup-settings-binding-modal-remove.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/project/admin/ugroup-settings-member-remove-modal.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/project/admin/user_groups/modal-ugroup-delete.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/project/admin/user_groups/modal-ugroup.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/project/labels/label-modal-add.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/project/labels/label-modal-delete.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/project/labels/label-modal-edit.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/project/members/modal-import-members.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/project/members/project-members-delete-modal.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/project/project-hierarchy-delete-modal.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/project/project_visibility.mustache | +2 | −2 | Go to diff View file |
| M | src/templates/resource_restrictor/allowed-projects-all-form-confirmation-modal-allow.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/resource_restrictor/allowed-projects-all-form-confirmation-modal-restrict.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/resource_restrictor/allowed-projects-list.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/widgets/contact-modal.mustache | +1 | −1 | Go to diff View file |
| M | src/www/scripts/project/admin/services/src/components/AddModal.vue | +7 | −1 | Go to diff View file |
| M | src/www/scripts/project/admin/services/src/components/EditModal.vue | +7 | −1 | Go to diff View file |
| M | src/www/scripts/project/registration/src/components/Information/Agreement/AgreementModal.vue | +7 | −1 | Go to diff View file |
| M | src/www/themes/common/tlp/doc/resources/flyover/modals/open-target/example.html | +1 | −1 | Go to diff View file |
| M | src/www/themes/common/tlp/doc/resources/flyover/modals/replace-placeholders/example.html | +1 | −1 | Go to diff View file |
| M | src/www/themes/common/tlp/doc/resources/flyover/modals/structure/example.html | +2 | −2 | Go to diff View file |
| M | src/www/themes/common/tlp/doc/resources/flyover/modals/types/example.html | +6 | −6 | Go to diff View file |
| M | src/www/themes/common/tlp/doc/resources/flyover/modals/usage/example.html | +3 | −3 | Go to diff View file |
| M | src/www/themes/common/tlp/doc/resources/visual-assets/colors/illustrations/doc.html | +1 | −1 | Go to diff View file |
| M | src/www/themes/common/tlp/src/scss/components/_modal.scss | +4 | −0 | Go to diff View file |