Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Build InlineComment representations with business objects

Download Browse

No functional change expected when listing the inline comments of a file through the REST API. Notes: - UserManager::getUserById can return null, but this case was never handled and would produce a fatal error. Now it will throw an exception and end up in the REST API log. part of story #32316 Update comments Change-Id: I9cf9dd4bf827e8a1290db103154100b52f747b44

+291 −82
Joris MASSON (jmasson) 2023-11-15 11:29
Joris MASSON (jmasson) 2023-11-15 15:17
21323175d06a5d3cf2f920897ae26a9d4daaa85b
48a469f58f29dbb3764f68ec6293c564e26ea581
git #tuleap/stable/21323175d06a5d3cf2f920897ae26a9d4daaa85b

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/include/PullRequest/InlineComment/Dao.php +9 −4 Go to diff View file
A plugins/pullrequest/include/PullRequest/InlineComment/SearchInlineCommentsOnFile.php +29 −0 Go to diff View file
A plugins/pullrequest/include/PullRequest/REST/v1/InlineComment/InlineCommentRepresentationBuilder.php +80 −0 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/PullRequestInlineCommentRepresentation.php +1 −4 Go to diff View file
D plugins/pullrequest/include/PullRequest/REST/v1/PullRequestInlineCommentRepresentationBuilder.php +0 −67 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/PullRequestsResource.php +2 −1 Go to diff View file
M plugins/pullrequest/tests/integration/InlineComment/InlineCommentDAOTest.php +12 −6 Go to diff View file
A plugins/pullrequest/tests/unit/REST/v1/InlineComment/InlineCommentRepresentationBuilderTest.php +107 −0 Go to diff View file
A plugins/pullrequest/tests/unit/Tests/Stub/SearchInlineCommentsOnFileStub.php +51 −0 Go to diff View file