Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix: project from source repository should be used when extracting

Download Browse

reference When user creates a new comment and reference an artifact into it, then the reference is extracted from the `source` repository. However, when the user updates his comment, the extracted reference is from the `destination` repository. The issue is we extract the reference from potentially two different project in the case of a pull request from a fork. To test: - Enable the feature flag: `tuleap config-set feature_flag_allow_pull_requests_comments_edition 1` - Create a fork of your git repository into diffrent project - Create a new pull request in the fork with a destination branch which is from the other project - Create a new comment with an artifact refrence - Edit the comment with a reference with the API explorer => The link of the artifact refrenced should be in the source project (the fork) Part of story #32316 Update comments Change-Id: Ia454c3903ff7483057cbb9b5244dd5c34ce6d7ba

+4 −4
Clarck Robinson (robinsoc) 2023-11-16 16:44
Clarck Robinson (robinsoc) 2023-11-16 16:44
4aec274623cb0f65b5a2cf903c0d99bd0a02021d
55edcba601e2a692a8a8d64332868724d4adc413
git #tuleap/stable/4aec274623cb0f65b5a2cf903c0d99bd0a02021d

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/include/PullRequest/REST/v1/Comment/PATCHCommentHandler.php +1 −1 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/Comment/PATCHInlineCommentHandler.php +3 −3 Go to diff View file