Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Inject last comments when viewing artifacts

Download Browse

Because we can fetch this in one query instead of fetching it bits by bits. This saves 333 queries and reduce by 17% the wall time for my reference artifact of 274 changesets. This change the way artifacts are rendred for artifact view only ATM to reduce the complexity, might be applied on other views later. While I was running perf investigation I found a reference to: request #9669 Field changes not displayed in last changeset comment and gerrit #7069 but no evidence on what was the source of the issue. Part of request #10069 Tracker comments don't scale up Change-Id: Iccfc4c19242f34376c5357d508657e738f21ecde

+139 −11
Manuel Vacelet (vaceletm) 2017-07-21 10:58
Thomas Gerbet (tgerbet) 2017-08-03 14:48
546271db696f9c6c248c9af33c700b636dc24bd9
c838e34d128e8fea77bfabe60b5202827aa632ec
git #tuleap/stable/546271db696f9c6c248c9af33c700b636dc24bd9

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/Tracker/Artifact/Tracker_Artifact.class.php +3 −2 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Tracker_Artifact_Changeset.class.php +56 −3 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Tracker_Artifact_ChangesetFactory.class.php +36 −0 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Tracker_Artifact_Followup_Item.class.php +9 −0 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Tracker_Artifact_PriorityHistoryChange.class.php +10 −0 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/View/Edit.class.php +3 −1 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/dao/Tracker_Artifact_Changeset_CommentDao.class.php +22 −5 Go to diff View file