stable

Clone or download

Read-only

Hold timestamp values instead of string for dates

request #23440 Date error prevents creation of Program Increments How to test: 1) Test scenario without redis - make sure redis is disabled: comment all fields of /etc/tuleap/conf/redis.inc, set $sys_nb_backend_workers = 0 in your local.inc - make sure your platform's language is english ($sys_lang = 'en_US'; in your local.inc) - set your user's language to French in the user preferences - Create a Program Increment in a Program. Choose any dates. => The mirror program increments should be created with the same dates in Team projects. 2) Test scenario with redis - uncomment all fields of redic.inc, set sys_nb_backend_workers = 2 in your local.inc - restart tuleap services (I restarted my "web" container) - Check /var/log/tuleap/worker_log. If it works there are new lines added about every minute. - Create a Program Increment in a Program. Choose any dates. => After a short delay, the mirror program increments should be created with the same dates in Team projects. 3) Duration - Setup a Program + Team with Duration fields for Timeframe semantic. - Create a Program Increment in a Program. => The mirror program increments should be created with the same duration in Team projects. Notes: - I'm sorry but I cannot really split this. Since we must change the internal representation of date fields, everything touching those fields/values must also change (or be broken). - I had created a unit test in unit/tests/ folder. It has been moved to tests/unit/. Change-Id: Ie8f116ab7eafb8025a21e39db3e5f6b0f7704d9b

Modified Files

Name
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/ArtifactCreatorAdapter.php +1 −1 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/ChangesetAdder.php +1 −1 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/IterationCreationProcessorBuilder.php +9 −8 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/ProgramIncrementCreationProcessorBuilder.php +3 −1 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/ProgramIncrementUpdateProcessorBuilder.php +3 −1 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/Source/Changeset/Values/ArtifactLinkValueFormatter.php +1 −1 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/Source/Changeset/Values/ChangesetValuesFormatter.php +13 −7 Go to diff View file
A plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/Source/Changeset/Values/DateValueFormatter.php +40 −0 Go to diff View file
A plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/Source/Changeset/Values/DateValueRetriever.php +73 −0 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/Source/Changeset/Values/DescriptionValueFormatter.php +1 −1 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/Source/Changeset/Values/FieldValuesGatherer.php +17 −28 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/Source/Changeset/Values/FieldValuesGathererRetriever.php +5 −1 Go to diff View file
R plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/Source/Fields/EndPeriodFieldReferenceProxy.php Go to diff View file
A plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/Source/Fields/EndDateFieldReferenceProxy.php +50 −0 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/Source/Fields/FieldPermissionsVerifier.php +4 −3 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/Source/Fields/SynchronizedFieldsGatherer.php +5 −4 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/AsynchronousCreation/MirroredTimeboxChangesetValues.php +6 −4 Go to diff View file
R plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Source/Changeset/Values/EndPeriodValue.php Go to diff View file
A plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Source/Changeset/Values/EndDateValue.php +52 −0 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Source/Changeset/Values/GatherFieldValues.php +1 −1 Go to diff View file
A plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Source/Changeset/Values/RetrieveDurationValue.php +34 −0 Go to diff View file
R plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Source/Changeset/Values/RetrieveEndPeriodValue.php Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Source/Changeset/Values/RetrieveStartDateValue.php +2 −1 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Source/Changeset/Values/SourceTimeboxChangesetValues.php +6 −3 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Source/Changeset/Values/StartDateValue.php +5 −2 Go to diff View file
R plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Source/Fields/EndPeriodFieldReference.php Go to diff View file
A plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Source/Fields/EndDateFieldReference.php +34 −0 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Source/Fields/RetrieveEndPeriodField.php +1 −1 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Source/Fields/SynchronizedFieldFromProgramAndTeamTrackersCollection.php +2 −3 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Source/Fields/SynchronizedFieldReferences.php +1 −1 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Source/Fields/VerifyFieldPermissions.php +2 −2 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/AsynchronousCreation/ArtifactCreatorAdapterTest.php +10 −8 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/AsynchronousCreation/ChangesetAdderTest.php +9 −6 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/AsynchronousCreation/ProgramIncrementCreationProcessorTest.php +2 −2 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/Source/Changeset/Values/ArtifactLinkValueFormatterTest.php +2 −2 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/Source/Changeset/Values/ChangesetValuesFormatterTest.php +33 −17 Go to diff View file
A plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/Source/Changeset/Values/DateValueFormatterTest.php +64 −0 Go to diff View file
A plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/Source/Changeset/Values/DateValueRetrieverTest.php +134 −0 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/Source/Changeset/Values/DescriptionValueFormatterTest.php +1 −1 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/Source/Changeset/Values/FieldValuesGathererTest.php +115 −56 Go to diff View file
R plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/Source/Fields/EndPeriodFieldReferenceProxyTest.php Go to diff View file
A plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/Source/Fields/EndDateFieldReferenceProxyTest.php +53 −0 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/Source/Fields/SynchronizedFieldsGathererTest.php +6 −2 Go to diff View file
M plugins/program_management/tests/unit/Builder/MirroredTimeboxChangesetValuesBuilder.php +35 −2 Go to diff View file
M plugins/program_management/tests/unit/Builder/SourceTimeboxChangesetValuesBuilder.php +37 −22 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/AsynchronousCreation/IterationCreationProcessorTest.php +2 −2 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/AsynchronousCreation/MirroredTimeboxChangesetValuesTest.php +77 −15 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/AsynchronousCreation/ProgramIncrementUpdateProcessorTest.php +2 −2 Go to diff View file
R plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramIncrement/Source/Changeset/Values/EndPeriodValueTest.php Go to diff View file
A plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramIncrement/Source/Changeset/Values/EndDateValueTest.php +40 −0 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramIncrement/Source/Changeset/Values/SourceTimeboxChangesetValuesTest.php +2 −2 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramIncrement/Source/Changeset/Values/StartDateValueTest.php +1 −1 Go to diff View file
R plugins/program_management/unit/tests/Domain/Team/MirroredTimebox/MirroredIterationTrackerIdentifierTest.php Go to diff View file
A plugins/program_management/tests/unit/Stub/DurationFieldReferenceStub.php +55 −0 Go to diff View file
R plugins/program_management/tests/unit/Stub/EndPeriodFieldReferenceStub.php Go to diff View file
M plugins/program_management/tests/unit/Stub/GatherFieldValuesStub.php +50 −10 Go to diff View file
M plugins/program_management/tests/unit/Stub/GatherSynchronizedFieldsStub.php +19 −8 Go to diff View file
R plugins/program_management/tests/unit/Stub/RetrieveEndPeriodValueStub.php Go to diff View file
A plugins/program_management/tests/unit/Stub/RetrieveEndDateValueStub.php +46 −0 Go to diff View file
M plugins/program_management/tests/unit/Stub/RetrieveEndPeriodFieldStub.php +27 −8 Go to diff View file
M plugins/program_management/tests/unit/Stub/RetrieveStartDateValueStub.php +6 −6 Go to diff View file
M plugins/program_management/tests/unit/Stub/SynchronizedFieldsStubPreparation.php +25 −3 Go to diff View file
M plugins/program_management/tests/unit/Stub/VerifyFieldPermissionsStub.php +4 −3 Go to diff View file