Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Started threads are not properly determined

Download Browse

part of story #29257 have a thread of comments How to test: Create multiple comments Reply to them, they will have different colors assigned If you post multiples replies to an existing thread, it keeps its color Change-Id: Ie4b7e70ad9fff4e815afa3110708674380e3f28a

+240 −27
Marie Ange Garnier (marieange) 2022-11-23 16:47
Marie Ange Garnier (marieange) 2022-11-25 15:46
841a10d462b2f0f1145708ad6bcee810df65360d
48592e82681d1fab040345c3c072926a018a1934
git #tuleap/stable/841a10d462b2f0f1145708ad6bcee810df65360d

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/db/install.sql +2 −2 Go to diff View file
A plugins/pullrequest/db/mysql/updates/2022/202211251412_make_color_column_not_nullable.php +63 −0 Go to diff View file
M plugins/pullrequest/include/PullRequest/Comment/Dao.php +1 −1 Go to diff View file
M plugins/pullrequest/include/PullRequest/Comment/Factory.php +1 −1 Go to diff View file
M plugins/pullrequest/include/PullRequest/Comment/ThreadCommentDao.php +3 −3 Go to diff View file
M plugins/pullrequest/include/PullRequest/InlineComment/Dao.php +1 −1 Go to diff View file
M plugins/pullrequest/include/PullRequest/InlineComment/InlineComment.php +1 −1 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/Comment/ThreadCommentColorAssigner.php +1 −1 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/Comment/ThreadCommentColorRetriever.php +7 −1 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/PullRequestInlineCommentRepresentationBuilder.php +1 −1 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/PullRequestsResource.php +2 −2 Go to diff View file
M plugins/pullrequest/include/PullRequest/Timeline/Factory.php +1 −1 Go to diff View file
A plugins/pullrequest/tests/integration/Comment/ThreadCommentDaoTest.php +119 −0 Go to diff View file
M plugins/pullrequest/tests/unit/InlineComment/InlineCommentCreatorTest.php +9 −6 Go to diff View file
M plugins/pullrequest/tests/unit/InlineComment/InlineCommentRetrieverTest.php +1 −1 Go to diff View file
M plugins/pullrequest/tests/unit/REST/v1/Comment/ThreadCommentColorAssignerTest.php +13 −3 Go to diff View file
M plugins/pullrequest/tests/unit/REST/v1/Comment/ThreadCommentColorRetreiverTest.php +14 −2 Go to diff View file