Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Stop relying on the the god PullRequest/Factory class in new

Download Browse

comment notification Use the dedicated class instead a god factory to retrieve a pull request by its id. No functionnal change expected Part of story #32316 Update comments Change-Id: I124a8d547c92405d082beb5ce5632d5cec1f981e

+79 −95
Clarck Robinson (robinsoc) 2023-11-14 17:30
Clarck Robinson (robinsoc) 2023-11-15 09:22
89e9397ba54c2c0c1a1f28ef0a63d008f6c6bdfb
b199588bfae6071ba77bfa675ba53d697c0df5e3
git #tuleap/stable/89e9397ba54c2c0c1a1f28ef0a63d008f6c6bdfb

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/include/PullRequest/Comment/Notification/PullRequestNewCommentNotificationToProcessBuilder.php +25 −26 Go to diff View file
M plugins/pullrequest/include/PullRequest/InlineComment/Notification/PullRequestNewInlineCommentNotificationToProcessBuilder.php +30 −31 Go to diff View file
M plugins/pullrequest/include/PullRequest/Notification/PullRequestNotificationSupport.php +2 −6 Go to diff View file
M plugins/pullrequest/tests/unit/Comment/Notification/PullRequestNewCommentNotificationToProcessBuilderTest.php +15 −19 Go to diff View file
M plugins/pullrequest/tests/unit/InlineComment/Notification/PullRequestNewInlineCommentNotificationToProcessBuilderTest.php +7 −13 Go to diff View file