stable

Clone or download

Read-only

feat: Check source Git repo exists

How to test: - fork a repository to another project - create a pull request from Fork project to Main project - create an inline and a global comment on the pull request - forge the database: edit the plugin_pullrequest_review table and change the repository_id to some bogus value for the pull request - edit your inline and global comments through the REST API. You should get error code 404 stating that the git repository cannot be found. part of story #32316 Update comments Change-Id: I88ab03f2121c281cfbcb5548cf4cf098efa1393c

Modified Files

Name
M plugins/git/include/RetrieveGitRepository.php +10 −0 Go to diff View file
M plugins/git/tests/unit/Tests/Stub/RetrieveGitRepositoryStub.php +0 −3 Go to diff View file
M plugins/pullrequest/include/PullRequest/Authorization/CannotAccessToPullRequestFault.php +4 −1 Go to diff View file
A plugins/pullrequest/include/PullRequest/Authorization/GitRepositoryNotFoundFault.php +36 −0 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/Comment/PATCHCommentHandler.php +12 −19 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/FaultMapper.php +2 −1 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/InlineComment/PATCHHandler.php +8 −6 Go to diff View file
M plugins/pullrequest/site-content/fr_FR/LC_MESSAGES/tuleap-pullrequest.po +8 −4 Go to diff View file
M plugins/pullrequest/site-content/pt_BR/LC_MESSAGES/tuleap-pullrequest.po +4 −0 Go to diff View file
M plugins/pullrequest/tests/unit/REST/FaultMapperTest.php +2 −0 Go to diff View file
M plugins/pullrequest/tests/unit/REST/v1/Comment/PATCHCommentHandlerTest.php +32 −11 Go to diff View file
M plugins/pullrequest/tests/unit/REST/v1/InlineComment/PATCHHandlerTest.php +25 −9 Go to diff View file