stable

Clone or download

Read-only

request #12132: Run (almost) all the SimpleTest tests in PHP 7.2

A few tests are not yet run in in PHP 7.2: * ForumML_InsertTest: does not run because of the dependency on PEAR Mail_Mime. This will be solved by the ongoing work in request #12126. * multiple tests in the OpenID Connect plugin: a few classes does not respect the method signatures when redefining methods. This will be solved with the fix for request #9527. * integration tests of the project import: our version of Mediawiki and the associated plugins are not compatible with PHP 7.2. Due to the scope of the required changes to make it work, it will be fixed in a dedicated request/story. However, besides Mediawiki, the project import feature is working in PHP 7.2 as it is already used in the REST and SOAP tests. Change-Id: I5288992050192818076756d0fd2254d5f8e69fae

Modified Files

Name
M Makefile +8 −13 Go to diff View file
M plugins/IM/include/IMPlugin.class.php +4 −4 Go to diff View file
M plugins/IM/include/jabbex_api/lib/jabberclass-0.9/class_Jabber.php +2 −2 Go to diff View file
M plugins/agiledashboard/tests/builders/anArtifactNode.php +6 −2 Go to diff View file
M plugins/cardwall/tests/CardwallConfigXmlExportTest.php +4 −0 Go to diff View file
D plugins/docman/tests/php7compatibletests.list +0 −23 Go to diff View file
M plugins/forumml/include/forummlPlugin.class.php +7 −6 Go to diff View file
M plugins/forumml/tests/ForumML_InsertTest.php +6 −3 Go to diff View file
D plugins/forumml/tests/php7compatibletests.list +0 −1 Go to diff View file
M plugins/fulltextsearch/include/ElasticSearch/SearchAdminClientFacade.class.php +3 −2 Go to diff View file
M plugins/fulltextsearch/include/SystemEvent_FULLTEXTSEARCH_DOCMAN_DELETE.class.php +3 −2 Go to diff View file
M plugins/fulltextsearch/tests/FullTextSearchTrackerActionsTest.php +6 −2 Go to diff View file
M plugins/git/include/Git/Driver/GerritLegacy.class.php +7 −5 Go to diff View file
M plugins/git/tests/GitRepositoryManagerTest.php +5 −1 Go to diff View file
M plugins/git/tests/GitTest.php +5 −2 Go to diff View file
D plugins/git/tests/php7compatibletests.list +0 −72 Go to diff View file
D plugins/graphontrackersv5/tests/php7compatibletests.list +0 −2 Go to diff View file
M plugins/ldap/include/LDAP_BackendSVN.class.php +6 −2 Go to diff View file
M plugins/ldap/tests/LDAP_BackendSVNTest.php +2 −2 Go to diff View file
D plugins/ldap/tests/php7compatibletests.list +0 −9 Go to diff View file
M plugins/mediawiki/include/MediawikiAdminController.class.php +0 −2 Go to diff View file
M plugins/mediawiki/include/ServiceMediawiki.class.php +7 −7 Go to diff View file
M plugins/mediawiki/www/DatabaseForgeMysql123.php +3 −3 Go to diff View file
M plugins/openidconnectclient/tests/Authentication/FlowTest.php +6 −1 Go to diff View file
M plugins/openidconnectclient/tests/Authentication/StateManagerTest.php +6 −1 Go to diff View file
M plugins/openidconnectclient/tests/Login/LoginUniqueAuthenticationUrlGeneratorTest.php +6 −1 Go to diff View file
D plugins/pullrequest/tests/php7compatibletests.list +0 −8 Go to diff View file
D plugins/statistics/tests/php7compatibletests.list +0 −2 Go to diff View file
D plugins/svn/tests/php7compatibletests.list +0 −15 Go to diff View file
D plugins/template/tests/php7compatibletests.list +0 −1 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Container.class.php +4 −8 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_Checkbox.class.php +3 −2 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_List.class.php +2 −1 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_List_OpenValue.class.php +6 −2 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_Radiobutton.class.php +3 −1 Go to diff View file
M plugins/tracker/include/Tracker/Hierarchy/Hierarchy.class.php +22 −10 Go to diff View file
M plugins/tracker/tests/Tracker/Action/CreateArtifactTest.php +2 −1 Go to diff View file
M plugins/tracker/tests/Tracker/Artifact/MailGateway/IncomingMessageInsecureBuilderTest.php +1 −1 Go to diff View file
M plugins/tracker/tests/Tracker/Hierarchy/HierarchyTest.php +19 −3 Go to diff View file
M plugins/tracker/tests/Tracker/Rule/Date/FactoryTest.php +2 −2 Go to diff View file
M plugins/tracker/tests/Tracker/Rule/List/FactoryTest.php +2 −2 Go to diff View file
M plugins/tracker/tests/TrackerManagerTest.php +16 −17 Go to diff View file
M plugins/tracker/tests/TrackerXmlImportTest.php +2 −1 Go to diff View file
M plugins/tracker/tests/Tracker_FormElement_Container_ColumnTest.php +6 −6 Go to diff View file
M plugins/tracker/tests/Tracker_FormElement_Container_FieldsetTest.php +1 −2 Go to diff View file
M plugins/tracker/tests/Tracker_FormElement_Field_ArtifactLinkTest.php +2 −2 Go to diff View file
M plugins/tracker/tests/Tracker_FormElement_Field_ListTest.php +5 −5 Go to diff View file
M plugins/tracker/tests/Tracker_FormElement_Field_List_Bind_UsersValueTest.php +7 −6 Go to diff View file
M plugins/tracker/tests/workflow/Trigger/RulesFactoryTest.php +5 −4 Go to diff View file
M plugins/tracker/tests/workflow/Trigger/RulesManagerTest.php +11 −3 Go to diff View file
M plugins/tracker/tests/workflow/WorkflowFactoryTest.php +8 −3 Go to diff View file
D plugins/webdav/tests/php7compatibletests.list +0 −11 Go to diff View file
M src/common/collection/Collection.class.php +6 −5 Go to diff View file
M src/common/include/Codendi_Request.class.php +5 −4 Go to diff View file
M src/common/project/OneStepCreation/OneStepCreationRequest.class.php +2 −2 Go to diff View file
M src/common/tracker/ArtifactRuleFactory.class.php +4 −4 Go to diff View file
M src/common/user/User.class.php +1 −1 Go to diff View file
M src/utils/php-launcher.sh +16 −6 Go to diff View file
M tests/bin/SimpleTest11x/RunTestSuite.php +7 −31 Go to diff View file
M tests/integration/ProjectImportTest.php +7 −2 Go to diff View file
D tests/php7compatibletests.list +0 −212 Go to diff View file
M tests/simpletest/common/Cryptography/Asymmetric/AsymmetricCryptoTest.php +22 −7 Go to diff View file
M tests/simpletest/common/Cryptography/ConcealedStringTest.php +8 −3 Go to diff View file
M tests/simpletest/common/Cryptography/Symmetric/SymmetricCryptoTest.php +8 −3 Go to diff View file
M tests/simpletest/common/collection/MapTest.php +17 −17 Go to diff View file
M tests/simpletest/common/dao/include/DataAccessTest.php +5 −0 Go to diff View file
M tests/simpletest/common/event/EventManagerTest.php +2 −2 Go to diff View file
M tests/simpletest/common/frs/FRSPackageTest.php +21 −9 Go to diff View file
M tests/simpletest/common/include/Codendi_HTMLPurifierTest.php +11 −10 Go to diff View file
M tests/simpletest/common/include/CookieManagerTest.php +5 −0 Go to diff View file
M tests/simpletest/common/include/HTTPRequestTest.php +75 −62 Go to diff View file
M tests/simpletest/common/include/SOAPRequestTest.php +1 −1 Go to diff View file
M tests/simpletest/common/plugin/PluginManagerTest.php +2 −2 Go to diff View file
M tests/simpletest/common/reference/ReferenceManagerTest.php +1 −1 Go to diff View file
M tests/simpletest/common/reference/ReferenceTest.php +23 −11 Go to diff View file
M tests/simpletest/common/tracker/ArtifactRuleFactoryTest.php +23 −11 Go to diff View file
M tests/simpletest/common/tracker/ArtifactRuleValueTest.php +19 −7 Go to diff View file
M tests/simpletest/common/tracker/ArtifactRuleValueViewTest.php +21 −9 Go to diff View file
M tests/simpletest/common/user/UserAccountValidityTest.php +5 −5 Go to diff View file
M tests/simpletest/common/user/UserManagerTest.php +21 −15 Go to diff View file
M tests/simpletest/common/user/UserTest.php +2 −1 Go to diff View file
M tests/simpletest/common/valid/Rule_FileTest.php +8 −8 Go to diff View file
M tests/simpletest/common/valid/ValidTest.php +35 −34 Go to diff View file