Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Stop relying on the the god Factory class in PullRequestUpdatedNotificationToProcessBuilder

Download Browse

Part of story #32316 Update comments No functionnal change expected Note: I also take the opportunity to remove the mock of the `UserManager` class Change-Id: I6857b794a427d99d8d3fa7f5ddddb7440280d9b0

+127 −208
Clarck Robinson (robinsoc) 2023-11-13 17:18
Clarck Robinson (robinsoc) 2023-11-14 10:57
a08febf8038d0a44ce068c3905b52f7f8f36bb72
7141a90bd393f8b33ef50eace55712b783c5ae7a
git #tuleap/stable/a08febf8038d0a44ce068c3905b52f7f8f36bb72

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/include/PullRequest/BranchUpdate/PullRequestUpdatedNotificationToProcessBuilder.php +63 −107 Go to diff View file
M plugins/pullrequest/include/PullRequest/Notification/PullRequestNotificationSupport.php +2 −2 Go to diff View file
M plugins/pullrequest/tests/unit/BranchUpdate/PullRequestUpdatedNotificationToProcessBuilderTest.php +56 −99 Go to diff View file
M plugins/pullrequest/tests/unit/Tests/Builders/PullRequestTestBuilder.php +6 −0 Go to diff View file