stable

Clone or download

Read-only

refactor: Use DateTimeImmutable for last edition dates

No functional change. Last edition date should be saved, retrieved and displayed as before for comments and inline comments. Notes: - Also introduce Option::map() to simplify conversions between UNIX timestamps and DateTimeImmutable - Post date will be changed in a dedicated patch to have smaller commits. part of story #32316 Update comments Change-Id: Idd22217f62ccb96c522212ab688461165f86a696

Modified Files

Name
M lib/frontend/option/README.md +1 −1 Go to diff View file
M plugins/pullrequest/include/PullRequest/Comment/Comment.php +9 −5 Go to diff View file
M plugins/pullrequest/include/PullRequest/Comment/Dao.php +4 −5 Go to diff View file
M plugins/pullrequest/include/PullRequest/InlineComment/Dao.php +2 −1 Go to diff View file
M plugins/pullrequest/include/PullRequest/InlineComment/InlineComment.php +7 −5 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/Comment/CommentRepresentation.php +1 −1 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/InlineComment/InlineCommentRepresentation.php +1 −1 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/PullRequestsResource.php +16 −5 Go to diff View file
M plugins/pullrequest/tests/unit/Comment/CommentTest.php +2 −2 Go to diff View file
M plugins/pullrequest/tests/unit/InlineComment/InlineCommentTest.php +2 −2 Go to diff View file
M plugins/pullrequest/tests/unit/REST/v1/Comment/PATCHCommentHandlerTest.php +5 −2 Go to diff View file
M plugins/pullrequest/tests/unit/REST/v1/InlineComment/PATCHHandlerTest.php +2 −2 Go to diff View file
M plugins/pullrequest/tests/unit/Tests/Builders/CommentTestBuilder.php +4 −8 Go to diff View file
M plugins/pullrequest/tests/unit/Tests/Builders/InlineCommentTestBuilder.php +3 −3 Go to diff View file
M plugins/pullrequest/tests/unit/Tests/Stub/CommentSearcherStub.php +10 −9 Go to diff View file
M plugins/pullrequest/tests/unit/Tests/Stub/InlineCommentSearcherStub.php +2 −1 Go to diff View file
M src/common/Option/Option.php +11 −1 Go to diff View file
M src/common/Option/README.md +32 −10 Go to diff View file
M tests/unit/common/Option/OptionTest.php +33 −1 Go to diff View file
M tests/unit/common/Option/TypeTest.php +27 −0 Go to diff View file