stable
Clone or download
Read-only
No functional change expected: - in the REST route to post a reply to an inline comment - in the mail notification for a new inline comment Notes: Use an interface so that we can stub it in tests. Use Builders instead of mocks whenever possible. Remove default rows for stubs, they should be replaced by Builders which do the same thing. Also added tests for missing branches in ParentIdValidators. part of story #32316 Update comments Change-Id: I8b86c3eea023e3884080170bc9ff1db38885364f
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/pullrequest/include/PullRequest/Comment/CommentSearcher.php | +12 | −0 | Go to diff View file |
| M | plugins/pullrequest/include/PullRequest/Comment/Dao.php | +0 | −14 | Go to diff View file |
| M | plugins/pullrequest/include/PullRequest/Comment/Notification/PullRequestNewCommentNotificationToProcessBuilder.php | +3 | −3 | Go to diff View file |
| M | plugins/pullrequest/include/PullRequest/InlineComment/Dao.php | +1 | −4 | Go to diff View file |
| M | plugins/pullrequest/include/PullRequest/InlineComment/InlineCommentRetriever.php | +7 | −11 | Go to diff View file |
| A | plugins/pullrequest/include/PullRequest/InlineComment/InlineCommentSearcher.php | +44 | −0 | Go to diff View file |
| M | plugins/pullrequest/include/PullRequest/InlineComment/Notification/PullRequestNewInlineCommentNotificationToProcessBuilder.php | +35 | −35 | Go to diff View file |
| M | plugins/pullrequest/include/PullRequest/REST/v1/Comment/ParentIdValidatorForComment.php | +4 | −3 | Go to diff View file |
| M | plugins/pullrequest/include/PullRequest/REST/v1/Comment/ParentIdValidatorForInlineComment.php | +26 | −12 | Go to diff View file |
| M | plugins/pullrequest/tests/unit/Builders/CommentTestBuilder.php | +26 | −1 | Go to diff View file |
| M | plugins/pullrequest/tests/unit/Builders/InlineCommentTestBuilder.php | +28 | −3 | Go to diff View file |
| M | plugins/pullrequest/tests/unit/Comment/CommentRetrieverTest.php | +8 | −3 | Go to diff View file |
| M | plugins/pullrequest/tests/unit/Comment/Notification/PullRequestNewCommentNotificationToProcessBuilderTest.php | +41 | −70 | Go to diff View file |
| M | plugins/pullrequest/tests/unit/InlineComment/InlineCommentRetrieverTest.php | +20 | −24 | Go to diff View file |
| M | plugins/pullrequest/tests/unit/InlineComment/Notification/PullRequestNewInlineCommentNotificationToProcessBuilderTest.php | +69 | −104 | Go to diff View file |
| M | plugins/pullrequest/tests/unit/PullRequestRetrieverTest.php | +11 | −4 | Go to diff View file |
| M | plugins/pullrequest/tests/unit/REST/v1/Comment/PATCHCommentHandlerTest.php | +23 | −9 | Go to diff View file |
| M | plugins/pullrequest/tests/unit/REST/v1/Comment/ParentIdValidatorForCommentTest.php | +43 | −53 | Go to diff View file |
| M | plugins/pullrequest/tests/unit/REST/v1/Comment/ParentIdValidatorForInlineCommentTest.php | +44 | −58 | Go to diff View file |
| M | plugins/pullrequest/tests/unit/Stub/CommentSearcherStub.php | +3 | −36 | Go to diff View file |
| A | plugins/pullrequest/tests/unit/Stub/InlineCommentSearcherStub.php | +61 | −0 | Go to diff View file |
| M | plugins/pullrequest/tests/unit/Stub/SearchPullRequestStub.php | +18 | −19 | Go to diff View file |