Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Make CommentRepresentation class immutable

Download Browse

Part of story #32316 Update comments The refactoring is needed to make psalm happy when returning the comment in `PATCH pull_request_comments/:id` No functionnal change expected Change-Id: Iff52c55917ee24627872f1564ffb135efec937d7

+261 −139
Clarck Robinson (robinsoc) 2023-10-26 14:40
Clarck Robinson (robinsoc) 2023-11-02 15:44
d0b57387ec5495bd9fe666137e038b0ce8e5f19e
607b33ca817a738984428cf825032fe8c1c11175
git #tuleap/stable/d0b57387ec5495bd9fe666137e038b0ce8e5f19e

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/include/PullRequest/Comment/Comment.php +14 −0 Go to diff View file
A plugins/pullrequest/include/PullRequest/REST/v1/Comment/CommentContent.php +33 −0 Go to diff View file
A plugins/pullrequest/include/PullRequest/REST/v1/Comment/CommentRepresentation.php +73 −0 Go to diff View file
A plugins/pullrequest/include/PullRequest/REST/v1/Comment/CommentRepresentationBuilder.php +70 −0 Go to diff View file
D plugins/pullrequest/include/PullRequest/REST/v1/CommentRepresentation.php +0 −98 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/PaginatedCommentsRepresentationsBuilder.php +15 −15 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/PaginatedTimelineRepresentationBuilder.php +9 −5 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/PullRequestsResource.php +47 −21 Go to diff View file
R plugins/pullrequest/tests/unit/REST/v1/CommentRepresentationTest.php Go to diff View file