Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: extract POST Handler for comments

Download Browse

No functional change expected when creating a new comment through the REST API. Notes: - Ideally, the POSTHandler should also do the validation: checking the parent ID is valid, fetching the pull request and its ref, etc. Since my main goal here is to eliminate the "0" id in Comment, I have left these out. Having a POSTHandler with unit tests that "just creates" the comment and adds default values is still better than before. part of story #32316 Update comments Change-Id: I4f1fc0e06616f4a4e62fd679ba824120cc1a7b7d

+280 −59
Joris MASSON (jmasson) 2023-12-01 11:27
Joris MASSON (jmasson) 2023-12-04 12:40
eb1df4a632a4649520ff0c44f90603a31ccc9e6c
c3ffa85b4d047e0d23820ca1b62b6d3fb910edb1
git #tuleap/stable/eb1df4a632a4649520ff0c44f90603a31ccc9e6c

Modified Files

Side by side diff
Inline diff
Name
A plugins/pullrequest/include/PullRequest/REST/v1/Comment/POSTCommentHandler.php +90 −0 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/CommentPOSTRepresentation.php +14 −8 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/PullRequestsResource.php +12 −25 Go to diff View file
M plugins/pullrequest/tests/rest/PullRequest/PullRequestsCommentsTest.php +19 −26 Go to diff View file
A plugins/pullrequest/tests/unit/REST/v1/Comment/POSTCommentHandlerTest.php +144 −0 Go to diff View file
M plugins/pullrequest/tests/unit/REST/v1/InlineComment/POSTHandlerTest.php +1 −0 Go to diff View file