Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Remove labels boxes in [Commits] and [Changes] tabs

Download Browse

Closes request #32631 homogenize pull-request labels styles The idea is to stop displaying the legacy labels-box component in the [Commits] and [Changes] tabs. Since the new overview has been deployed, the edition of labels is no more implemented as a widget. Hence, keeping a labels box in the headers does not feel quite right anymore design-wise. This contribution allows the labels box to be displayed only on the legacy overview tab. How to test: - When the new overview is enabled in the project --> No labels-box is displayed in the header of the [Commits] and the [Changes] tabs - When the new overview is disabled in the project --> Still no labels box displayed in the [Commits] and [Changes] tabs --> A label box is displayed in the overview tab's header Change-Id: I67b0b2c1403d327415ff3a8563c5732c573ea97a

+168 −12
Thomas Gorka (tgorka) 2023-06-22 16:59
Thomas Gorka (tgorka) 2023-06-29 11:30
ebab46882a1e3dd300d108010c7663835b184a30
aed75b18212181dec7bee5eb4fa3982864c29356
git #tuleap/stable/ebab46882a1e3dd300d108010c7663835b184a30

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentPresenterBuilder.test.ts +3 −2 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentPresenterBuilder.ts +1 −4 Go to diff View file
A plugins/pullrequest/scripts/pullrequests-app/src/app/pull-request/header/LegacyLabelsBoxDisplay.test.ts +38 −0 Go to diff View file
A plugins/pullrequest/scripts/pullrequests-app/src/app/pull-request/header/LegacyLabelsBoxDisplay.ts +28 −0 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/pull-request/header/header-controller.js +14 −4 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/pull-request/header/header.tpl.html +4 −2 Go to diff View file
A plugins/pullrequest/scripts/pullrequests-app/src/app/shared-properties/shared-properties-service.d.ts +22 −0 Go to diff View file
A plugins/pullrequest/scripts/pullrequests-app/src/app/types.ts +23 −0 Go to diff View file
A plugins/pullrequest/scripts/pullrequests-app/tests/stubs/AngularUIRouterStateStub.ts +35 −0 Go to diff View file