Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Stop relying on the the god PullRequest/Factory class in new

Download Browse

ItemLabeledCollector Use the dedicated class instead a god factory to retrieve a pull request by its id. No functionnal change expected, you can still label and see labeled pull requests Part of story #32316 Update comments Change-Id: I712014b88a77f930810e1625d6bc64c94939c270

+104 −125
Clarck Robinson (robinsoc) 2023-11-30 11:20
Clarck Robinson (robinsoc) 2023-11-30 16:14
ed52f710aedf49fea3a0b2969bad6caf51b05156
afcce460ef63073e635395f5f46db8849f034442
git #tuleap/stable/ed52f710aedf49fea3a0b2969bad6caf51b05156

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/include/PullRequest/Label/LabeledItemCollector.php +32 −84 Go to diff View file
M plugins/pullrequest/include/pullrequestPlugin.php +2 −1 Go to diff View file
M plugins/pullrequest/tests/unit/BranchUpdate/PullRequestUpdatedNotificationToProcessBuilderTest.php +4 −4 Go to diff View file
M plugins/pullrequest/tests/unit/Comment/Notification/PullRequestNewCommentNotificationToProcessBuilderTest.php +2 −2 Go to diff View file
M plugins/pullrequest/tests/unit/Comment/Notification/UpdatedCommentNotificationToProcessBuilderTest.php +2 −2 Go to diff View file
M plugins/pullrequest/tests/unit/InlineComment/Notification/PullRequestNewInlineCommentNotificationToProcessBuilderTest.php +1 −1 Go to diff View file
M plugins/pullrequest/tests/unit/InlineComment/Notification/UpdatedInlineCommentNotificationToProcessBuilderTest.php +1 −1 Go to diff View file
M plugins/pullrequest/tests/unit/Label/LabeledItemCollectorTest.php +28 −19 Go to diff View file
M plugins/pullrequest/tests/unit/PullRequestRetrieverTest.php +1 −1 Go to diff View file
M plugins/pullrequest/tests/unit/REST/v1/AccessiblePullRequestRESTRetrieverTest.php +2 −2 Go to diff View file
M plugins/pullrequest/tests/unit/REST/v1/Comment/PATCHCommentHandlerTest.php +1 −1 Go to diff View file
M plugins/pullrequest/tests/unit/REST/v1/InlineComment/PATCHHandlerTest.php +1 −1 Go to diff View file
M plugins/pullrequest/tests/unit/REST/v1/PullRequestWithGitReferenceRetrieverTest.php +1 −1 Go to diff View file
M plugins/pullrequest/tests/unit/Tests/Builders/PullRequestTestBuilder.php +6 −0 Go to diff View file
M plugins/pullrequest/tests/unit/Tests/Stub/SearchPullRequestStub.php +20 −5 Go to diff View file