Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #13068 Start enforcing Tuleap PHP coding standard in CI pipelines
    Actions
    Infos
    #13068
    Thomas Gerbet (tgerbet)
    2019-04-29 09:11
    2019-03-01 17:13
    13936
    Details
    Start enforcing Tuleap PHP coding standard in CI pipelines
    Currently the PHP coding standard is only enforced through a pre-commit hook and things might be missed.

    This step should be enforced by the CI.


    PHPCS [0] is not able to silence an existing set of issue in the codebase. As such, and to avoid too much false-positive, the sane approach [1] seems to progressively add rule to enforce to fix the corresponding issues all over the codebase.

    The existing pre-commit hook will be kept as is to try to do the best it can to detect issues and the CI will enforce a subset of the ruleset.


    To test the approach, a new coding standard rule is going to be added: the unused use in the PHP files will now be rejected.


    [0] https://github.com/squizlabs/PHP_CodeSniffer/
    [1] https://github.com/squizlabs/PHP_CodeSniffer/issues/2094#issuecomment-409688782
    Dev tools
    Empty
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Empty
    Closed
    2019-03-18
    Attachments
    Artifact links

    Releases

    Fixed in

    Artifact ID Project Tracker Summary Status Last Update Date Submitted By Assigned to
    rel #12561 Tuleap Releases 11.0 Delivered 2019-04-07 00:54 Manuel Vacelet (vaceletm)
    Empty
    References
    Referencing request #13068

    Artifact Tracker v5

    request #13551 PhpWiki notification broken
    request #13708 Cleanup unused use statements and enforce it in the Tuleap PHP coding standards

    Git commit

    tuleap/tuleap/stable

    Merge commit 'refs/changes/61/14261/23' of ssh://gerrit.tuleap.net:29418/tuleap into HEAD 9410c4414e
    User avatar Yannis ROSSETTO (rossettoy) , 2019-03-06 13:33
    request #13068: Start enforcing Tuleap PHP coding standard in CI pipelines a3bac5c913
    User avatar Thomas Gerbet (tgerbet) , 2019-03-05 19:33
    Merge commit 'refs/changes/14/14314/1' of ssh://gerrit.tuleap.net:29418/tuleap into HEAD e1f4d3461d
    User avatar Nicolas Terray (nterray) , 2019-03-06 16:52
    Revert "request #13068: Start enforcing Tuleap PHP coding standard in CI pipelines" 44afd39474
    User avatar Thomas Gerbet (tgerbet) , 2019-03-06 16:34
    Merge commit 'refs/changes/16/14316/2' of ssh://gerrit.tuleap.net:29418/tuleap into HEAD fffd56b898
    User avatar Yannis ROSSETTO (rossettoy) , 2019-03-13 15:32
    request #13068: Start enforcing Tuleap PHP coding standard in CI pipelines 0b7f4afabd
    User avatar Thomas Gerbet (tgerbet) , 2019-03-06 19:18
    Referenced by request #13068

    Artifact Tracker v5

    rel #12561 11.0

    Other

    gerrit #14261
    gerrit #14314
    gerrit #14316
    Display settings

    Follow-ups

    User avatar
    Thomas Gerbet (tgerbet)2019-03-18 15:13
    Initial integration seems to work as expected let's close.
    • Status changed from Under review to Closed
    • Close date set to 2019-03-18
    User avatar
    Thomas Gerbet (tgerbet)2019-03-06 18:18
    Let's try again with something less aggressive than the removal of unused use statements. Let's try to forbid the usage of the PHP short open tag, see gerrit #14316.
    • Status changed from Reopen to Under review