Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #13708 Cleanup unused use statements and enforce it in the Tuleap PHP coding standards
    Actions
    Infos
    #13708
    Thomas Gerbet (tgerbet)
    2019-12-30 14:44
    2019-08-01 17:26
    14901
    Details
    Cleanup unused use statements and enforce it in the Tuleap PHP coding standards
    So once again I got a contribution rejected [0] only because I have left a unused use statement. This sort of reviews are mostly useless and are a waste of time for both the reviewer ad the contributor.
    The reviewer should be focused on finding bugs, security issues or design flaws in the architecture (or anything that increase the code quality) not on things that have no impact (or so small it's hardly measurable) at the execution and that can not become an issue in the long term maintenance of the software.

    This request is introduce a sniff to catch the unused use statements early in the dev process and autofix them.
    This was already attempted in request #13068 but due to a bug in the sniff, it was reverted. The bug has been fixed but a release of slevomat/coding-standard has not yet been released with it. In the meantime I'm just going to pull the fixed sniff in our sources.



    [0] https://gerrit.tuleap.net/c/tuleap/+/15653/1
    Dev tools
    All
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Thomas Gerbet (tgerbet)
    Closed
    2019-12-30
    Attachments
    Artifact links

    Releases

    Fixed in

    Artifact ID Project Tracker Summary Status Last Update Date Submitted By Assigned to
    rel #14137 Tuleap Releases 11.10 Delivered 2020-02-07 14:53 Manuel Vacelet (vaceletm)
    Empty
    References
    Referencing request #13708

    Git commit

    tuleap/tuleap/stable

    Update PHP CodeSniffer to 3.4.2 9eb3cee9b5
    User avatar Thomas Gerbet (tgerbet) , 2019-08-01 21:35
    Merge commit 'refs/changes/44/17044/3' of ssh://gerrit.tuleap.net:29418/tuleap into HEAD 80efce2169
    User avatar Marie Ange Garnier (marieange) , 2019-12-30 11:06
    Update to slevomat/coding-standard 6.0 0fcad2cd78
    User avatar Thomas Gerbet (tgerbet) , 2019-12-27 09:49
    request #13708: Cleanup unused use statements and enforce it in the Tuleap PHP coding standards 9c64d68cd6
    User avatar Thomas Gerbet (tgerbet) , 2019-12-29 11:40
    request #13708: Cleanup unused use statements 926be7ba90
    User avatar Thomas Gerbet (tgerbet) , 2019-12-30 12:34
    request #13708: Cleanup unused use statements 8851619bb1
    User avatar Thomas Gerbet (tgerbet) , 2019-12-30 12:37
    request #13708: Cleanup unused use statements b6aaf22e9d
    User avatar Thomas Gerbet (tgerbet) , 2019-12-30 12:30
    request #13708: Cleanup unused use statements b9514cadd3
    User avatar Thomas Gerbet (tgerbet) , 2019-12-30 12:32
    request #13708: Cleanup unused use statements 5ec148baeb
    User avatar Thomas Gerbet (tgerbet) , 2019-12-30 13:52
    Display settings

    Follow-ups

    User avatar
    Thomas Gerbet (tgerbet)2019-08-02 17:17
    Can't really pull the sniff on its own, the recent changes made to it also require some new helpers. I will patiently wait for a release.
    • Status changed from Under implementation to Waiting for information