Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #16620 One class per file
    Actions
    Infos
    #16620
    Nicolas Terray (nterray)
    2020-09-08 11:49
    2020-08-28 16:58
    17926
    Details
    One class per file
    PSR-1 says that "each class is in a file by itself":
    https://www.php-fig.org/psr/psr-1/#3-namespace-and-class-names
    Dev tools
    All
    Empty
    • [ ] enhancement
    • [x] internal improvement
    Empty
    Stage
    Nicolas Terray (nterray)
    Closed
    2020-09-08
    Attachments
    Artifact links

    Releases

    Fixed in

    Artifact ID Project Tracker Summary Status Last Update Date Submitted By Assigned to
    rel #14819 Tuleap Releases 12.0 Delivered 2020-09-30 09:53 Manuel Vacelet (vaceletm)
    Empty
    References
    Referencing request #16620

    Git commit

    tuleap/tuleap/stable

    Split files that contains more than one class 6b665657c9
    User avatar Nicolas Terray (nterray) , 2020-08-31 12:19
    Split files that contains more than one class in Docman 6fc5813f5c
    User avatar Nicolas Terray (nterray) , 2020-09-01 17:17
    Do not exclude PSR1.Classes.ClassDeclaration.MultipleClasses 5df32feed9
    User avatar Nicolas Terray (nterray) , 2020-09-07 15:17
    Referenced by request #16620

    Artifact Tracker v5

    rel #14819 12.0

    Other

    gerrit #20016
    gerrit #20042
    gerrit #20108
    Display settings

    Follow-ups

    User avatar
    Thomas Gerbet (tgerbet)2020-09-01 18:22
    gerrit #20042 integrated into Tuleap 11.18.99.117.

    However this cannot be closed yet. This can be closed once the rule PSR1.Classes.ClassDeclaration.MultipleClasses exclusion (or at least kept but with only very specific exclusion paths) can be removed from tests/phpcs/tuleap-ruleset-minimal.xml to be sure the issue is not introduced again in the codebase.