At the moment, psalm on gerrit patches only inspect the files that were modified. While it's already a good first level of analysis, it's not paranoid enough.

For instance PS1 of gerrit #25401 introduce a change in the constructor of src/tuleap-cfg/Command/SetupTuleapCommand.php but I forgot to change the object construction in tuleap-cfg.php. As this file was not modified, it was not analyzed by psalm. Fortunatly, the code is being called somewhere else so the CI caught the issue but not in a way that was helpful.

I propose to force psalm to analyze the whole code base at each patch.

For the record, with partial analysis the step takes ~1mn and with whole analyis takes ~5mn. But that's not that much an issue b/c build_and_run takes more than 9mn.